Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(components): fix cursor state on EmptySelectorButton #16283

Merged
merged 3 commits into from
Sep 18, 2024
Merged

fix(components): fix cursor state on EmptySelectorButton #16283

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b9d5f92
fix(components): fix cursor state on `EmptySelectorButton`
ncdiehl11 Sep 18, 2024
74b1379
Merge branch 'edge' into components_fix-emptyselectorbutton-cursor
ncdiehl11 Sep 18, 2024
248a03c
use constants
ncdiehl11 Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions components/src/atoms/buttons/EmptySelectorButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ export function EmptySelectorButton(
border: none;
width: ${buttonSizing};
height: ${buttonSizing};
cursor: ${disabled ? 'default' : 'pointer'};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you merge edge or rebase, you will be able to use the followings.

Suggested change
cursor: ${disabled ? 'default' : 'pointer'};
cursor: ${disabled ? CURSOR_DEFAULT : CURSOR_POINTER};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#16136

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Koji

&:focus-visible {
outline: 2px solid ${COLORS.white};
box-shadow: 0 0 0 4px ${COLORS.blue50};
Expand Down
Loading