fix(components): fix cursor state on EmptySelectorButton
#16283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When hovering an enabled `EmptySelectorButton`, (ex: walking through creating a protocol in PD redesign and adding pipettes/modules), the cursor should be `pointer`. Closes RQA-3197
koji
reviewed
Sep 18, 2024
| @@ -41,6 +41,7 @@ export function EmptySelectorButton( | |||
| border: none; | |||
| width: ${buttonSizing}; | |||
| height: ${buttonSizing}; | |||
| cursor: ${disabled ? 'default' : 'pointer'}; | |||
There was a problem hiding this comment.
if you merge edge or rebase, you will be able to use the followings.
Suggested change
| cursor: ${disabled ? 'default' : 'pointer'}; | |
| cursor: ${disabled ? CURSOR_DEFAULT : CURSOR_POINTER}; |
jerader
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When hovering an enabled
EmptySelectorButton, (ex: walking through creating a protocol in PD redesign and adding pipettes/modules), the cursor should bepointer.Closes RQA-3197
Test Plan and Hands on Testing
EmptySelectorButtonfor "Add a pipette and tips" and individual module additions produces a pointer cursorChangelog
add cursor style to
EmptySelectorButtonReview requests
see test plan
Risk assessment
low