-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): static meniscus-relative aspiration #16209
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
26e1dc7
initial implementation with notes
pmoegenburg 83b0db0
Merge branch 'edge' into EXEC-692-variable-starting-height
pmoegenburg f73e60f
updated and cleaned up implementation
pmoegenburg fe985f7
update
pmoegenburg 165dcc7
updated implementation to use WellOrigin.MENISCUS
pmoegenburg cbf2482
undid changes that belong in EXEC-640 branch
pmoegenburg 12b809a
Merge branch 'edge' into EXEC-692-variable-starting-height
pmoegenburg 9b79103
cleaned up comments
pmoegenburg d55f398
update
pmoegenburg d9cbfa6
revert changes that are now in EXEC-643 branch
pmoegenburg 5b95da5
update
pmoegenburg aeae324
update meniscus methods to utilize volume
pmoegenburg 0e65cd3
to minimize diff
pmoegenburg cb088a8
removed comment
pmoegenburg c435826
format
pmoegenburg 4b4f97c
update
pmoegenburg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -21,6 +21,7 @@ | |
UnexpectedTipRemovalError, | ||
UnexpectedTipAttachError, | ||
) | ||
from opentrons_shared_data.robot.types import RobotType | ||
|
||
from ...disposal_locations import TrashBin, WasteChute | ||
from opentrons.protocol_api._nozzle_layout import NozzleLayout | ||
|
@@ -77,6 +78,10 @@ def __init__( | |
) | ||
self._liquid_presence_detection = False | ||
|
||
@property | ||
def robot_type(self) -> RobotType: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also not true, legacy core can be used on ot3. |
||
return "OT-2 Standard" | ||
|
||
def get_default_speed(self) -> float: | ||
return self._default_speed | ||
|
||
|
@@ -484,6 +489,12 @@ def retract(self) -> None: | |
"""Retract this instrument to the top of the gantry.""" | ||
self._protocol_interface.get_hardware.retract(self._mount) # type: ignore [attr-defined] | ||
|
||
def get_last_measured_liquid_height(self, well_core: WellCore) -> Optional[float]: | ||
"""This will never be called because it was added in API 2.21.""" | ||
assert ( | ||
False | ||
), "get_last_measured_liquid_height only supported in API 2.21 & later" | ||
|
||
def detect_liquid_presence(self, well_core: WellCore, loc: types.Location) -> bool: | ||
"""This will never be called because it was added in API 2.20.""" | ||
assert False, "detect_liquid_presence only supported in API 2.20 & later" | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not true, You can use legacy core on a ot3