feat(api): static meniscus-relative aspiration #16209
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## edge #16209 +/- ##
==========================================
+ Coverage 73.62% 80.95% +7.32%
==========================================
Files 41 106 +65
Lines 2992 3776 +784
==========================================
+ Hits 2203 3057 +854
+ Misses 789 719 -70
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ryanthecoder
reviewed
Oct 9, 2024
| @@ -64,6 +65,10 @@ def __init__( | |||
| ) | |||
| self._liquid_presence_detection = False | |||
|
|
|||
| @property | |||
| def robot_type(self) -> RobotType: | |||
There was a problem hiding this comment.
This is not true, You can use legacy core on a ot3
ryanthecoder
reviewed
Oct 9, 2024
| @@ -77,6 +78,10 @@ def __init__( | |||
| ) | |||
| self._liquid_presence_detection = False | |||
|
|
|||
| @property | |||
| def robot_type(self) -> RobotType: | |||
There was a problem hiding this comment.
Also not true, legacy core can be used on ot3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds the meniscusRelative and offsetFromMeniscusMm params to liquid handling Protocol API actions
Test Plan and Hands on Testing
Changelog
Review requests
Risk assessment