fix(app): scrolling issue in deck hardware screen #16202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjhuff
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This problem is caused by #15897 (we used to use a modal for the deck map). However, I guess the fundamental problem is that we need to pass the specific value to control the deck map's size. (I think we discussed this before during app&ui standup). Also, it may have something to do with the current implementation of the scroll bar 😭.
I think we will need to re-examine the implementation method.
close RQA-3150
after
deck_hardwere-scroll.mov
Test Plan and Hands on Testing
Changelog
ProtocolSetupModulesAndDeckas ModulesAndDeckMapView's parentReview requests
Risk assessment
low