Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(app): change map view action button behavior #15897

Merged
merged 2 commits into from
Aug 6, 2024
Merged

refactor(app): change map view action button behavior #15897

merged 2 commits into from
Aug 6, 2024

Conversation

brenthagen
Copy link
Contributor

Overview

changes the deck hardware and labware map views from modals to page content. alters the floating action button to remove the default icon.

closes PLAT-391, PLAT-392

Screen Shot 2024-08-06 at 10 29 48 AM Screen Shot 2024-08-06 at 10 29 37 AM

Test Plan and Hands on Testing

verified map view/list view toggle, updated unit tests

Changelog

  • Changes map view action button behavior

Review requests

check toggling between list/map view

Risk assessment

low

@brenthagen
refactor(app): change map view action button behavior
77d608b 
changes the deck hardware and labware map views from modals to page content. alters the floating
action button to remove the default icon.

close PLAT-391, PLAT-392
@brenthagen
fix test
b76c746
@brenthagen brenthagen requested review from smb2268, ncdiehl11 and a team August 6, 2024 14:36
@brenthagen brenthagen requested a review from a team as a code owner August 6, 2024 14:36
@brenthagen brenthagen removed the request for review from a team August 6, 2024 14:36
smb2268
smb2268 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@smb2268 smb2268 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out and it works as expected!

@brenthagen brenthagen merged commit cfaffe4 into chore_release-8.0.0 Aug 6, 2024
25 checks passed
@brenthagen brenthagen deleted the app_change-map-view-action-button-behavior branch August 6, 2024 18:45
@koji koji mentioned this pull request Sep 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smb2268 smb2268 smb2268 approved these changes

@ncdiehl11 ncdiehl11 Awaiting requested review from ncdiehl11

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brenthagen @smb2268