Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(app): update new confirmation buttons on protocol setup #16132

Merged
merged 3 commits into from
Aug 27, 2024
Merged

fix(app): update new confirmation buttons on protocol setup #16132

merged 3 commits into from
Aug 27, 2024

Conversation

ncdiehl11
Copy link
Collaborator

@ncdiehl11 ncdiehl11 commented Aug 26, 2024 •
edited
Loading

Overview

Designs now specify explicit confirmation "green checks" for LPC, labware, and liquid setup. Here, I update the copy for LPC confirmation from 'Confirm placements' to 'Confirm offsets', along with adding new copy above the offset table I also update the button styles from 'default' to 'rounded' to reflect designs.

In addition, I add an InfoScreen showing no offset data if no non-identity vector offsets exit.

Closes RQA-3104

Test Plan and Hands on Testing

  • Begin protocol setup and select LPC setup step
  • Verify that confirmation button copy and style match designs
  • Repeat with labware and liquids setup steps
  • Smoke test Desktop app to make sure other instances of InfoScreen are not affected
Screenshot 2024-08-26 at 4 53 15 PM Screenshot 2024-08-26 at 3 27 22 PM Screenshot 2024-08-26 at 4 34 57 PM

Changelog

  • change copy for LPC confirmation button
  • update button protocol setup screen confirmation buttons' styles to rounded
  • add InfoScreen rather than table if no non-identity offsets applied
  • add new copy above offset table

Review requests

  • see test plan

Risk assessment

low

@ncdiehl11
fix(app): update new confirmation buttons on protocol setup
cc10274 
Designs now specify explicit confirmation "green checks" for LPC, labware, and liquid setup. Here, I
update the copy for LPC confirmation from 'Confirm placements' to 'Confirm offsets'. I also update
the button styles from 'default' to 'rounded' to reflect designs.

Closes RQA-3104
@ncdiehl11 ncdiehl11 marked this pull request as ready for review August 26, 2024 19:39
@ncdiehl11 ncdiehl11 requested a review from a team as a code owner August 26, 2024 19:39
@ncdiehl11 ncdiehl11 requested review from jerader and removed request for a team August 26, 2024 19:39
sfoster1
sfoster1 approved these changes Aug 26, 2024
View reviewed changes
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, thanks!

@ncdiehl11 ncdiehl11 requested a review from sfoster1 August 26, 2024 21:39
@ncdiehl11
Copy link
Collaborator Author

Oh, thanks!

re-requested review after a bigger change that I noticed after checking Figma! 😓

koji
koji approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ncdiehl11 ncdiehl11 merged commit 80a446a into chore_release-8.0.0 Aug 27, 2024
48 checks passed
@ncdiehl11 ncdiehl11 deleted the app_fix-odd-confirmation-buttons branch August 27, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koji koji koji approved these changes

@jerader jerader Awaiting requested review from jerader jerader is a code owner automatically assigned from Opentrons/js

@sfoster1 sfoster1 Awaiting requested review from sfoster1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncdiehl11 @koji @sfoster1