style(app, protocol-designer, components): promote no-unsafe-argument from warn to error, fix all #15402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… from warn to error, fix all Promote the typescript eslint rule for no-unsafe-argument to error and fix all outstanding instances in the mono repo
jerader
reviewed
Jun 17, 2024
Comment on lines
+11
to
+14
| properties: Record<string, unknown> | ||
| superProperties?: Record<string, unknown> | ||
| } | ||
| | { superProperties: { [key: string]: unknown } } | ||
| | { superProperties: Record<string, unknown> } |
There was a problem hiding this comment.
does this error with the new lint error or is this a random refactor? (asking because i 100% prefer it written this way).
There was a problem hiding this comment.
It is a slightly unrelated fix, and probably not necessary here. I'm actually in favor of the index-signature syntax of the Record keyword myself. I think we probably want to relax or invert that typescript eslint rule. I'll tackle that in the next PR.
jerader
approved these changes
Jun 17, 2024
|
this is the app whitescreen error i am getting 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Promote the typescript eslint rule for no-unsafe-argument to error and fix all outstanding instances
in the mono repo
Review requests
Risk assessment
medium, should have no effect on code, but many files were touched