-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app, shared-data, components): implement base CSV file RTP UI #15410
Conversation
This PR updates and implements the new csv_file type RTP in components across the app, ODD, and components library.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks great! nice work! all my comments are pretty minimal. Once they're addressed and Koji's comments are addressed, this is good to go 🎉 🦖 🌮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you for updating types and slideouts.
they always require a lot of work 😁
closes AUTH-449
closes AUTH-457
closes AUTH-458
closes AUTH-459
closes AUTH-494
Overview
This PR updates and implements the new csv_file type RTP in components across the app, ODD, and
components library.
Test Plan
Desktop
requires upload
chipupdated
chipODD
updated
chipChangelog
Review requests
authorship js. This is a sizable PR due to the new types changes affecting components and utilities across the app, so I am happy to sit down and work through a review with any reviewers.
Risk assessment
medium. I introduce a lot of new code to the UI, but any HTTP API communication should be unaffected in this PR.