Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add tiprack selection step to quick transfer flow #14950

Merged
merged 4 commits into from
Apr 22, 2024

Conversation

smb2268
Copy link
Contributor

@smb2268 smb2268 commented Apr 18, 2024

fix PLAT-290

Overview

Implement the tip rack selection screen for the quick transfer wizard flow

Test Plan

  1. Launch quick transfer flow on ODD or ODD dev app
  2. Select a pipette and proceed to step 3
  3. You should see the pipette's default tip racks as options
  4. The continue button should be disabled if no tiprack is selected
  5. You should also see that if you go back to the selected pipette screen, the previously selected tiprack should be wiped
Screen Shot 2024-04-18 at 4 15 24 PM Screen Shot 2024-04-18 at 4 15 16 PM

Changelog

  1. Added tip rack selection screen and test
  2. Adjusted some styling to be in line with designs

Review requests

Quick look through the changes - I've tested this out a bit

Risk assessment

Low, behind FF

@smb2268 smb2268 self-assigned this Apr 18, 2024
@smb2268 smb2268 requested a review from a team as a code owner April 18, 2024 20:23
@smb2268 smb2268 force-pushed the app_quick-transfer-tiprack branch from 9ea79c3 to b152da3 Compare April 18, 2024 20:52
Copy link
Collaborator

@jerader jerader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm! Will custom tipracks be supported in quick transfer?

@smb2268
Copy link
Contributor Author

smb2268 commented Apr 22, 2024

nice! lgtm! Will custom tipracks be supported in quick transfer?

@jerader MVP isn't going to support any custom labware but we may add that down the line!

@smb2268 smb2268 merged commit b42927a into edge Apr 22, 2024
48 checks passed
@smb2268 smb2268 deleted the app_quick-transfer-tiprack branch April 22, 2024 15:31
y3rsh added a commit that referenced this pull request Apr 23, 2024
* edge: (194 commits)
  fix(app): clone run with RTPs from HistoricalProtocolRun (#14959)
  fix(api): Filter out `air_gap()` calls as higher-order commands (#14985)
  fix(app): fix infinitely re-rendering/never rendering firmware success toasts (#14981)
  feat(api): add option to ignore different tip presence states (#14980)
  feat(opentrons-ai-client) add input textbox to container (#14968)
  fix(app): add robotSerialNumber to proceedToRun event (#14976)
  fix(api): remove homing patch fix for right mount when a 96-channel is attached (#14975)
  feat(api-client,app,react-api-client): upload splash logo from desktop app (#14941)
  fix(robot-server): notify /runs when a non-current run is deleted (#14974)
  feature(api, robot-server): Allow fixit commands to recover from an error (#14908)
  feat(hardware-testing): enable multi sensor processing in liquid probe (#14883)
  fix(app): prevent "run again" banner from rendering after navigating away from the current run (#14973)
  refactor(components): refactor roundtab stories (#14956)
  refactor(protocol-designer): assign module slot in createFileWizard instead of modal (#14951)
  fix(app, api-client): fix choose protocol slideout issue (#14949)
  refactor(protocol-designer): tip position modal max values round down (#14972)
  feat(app): add tiprack selection step to quick transfer flow (#14950)
  ci(shared-data): install dependencies in workflow (#14958)
  fix(components): fix icon stories (#14969)
  feat(opentrons-ai-client): introduce react-markdown to chat display component (#14965)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants