chore: remove downgrade npm #14898
Merged
chore: remove downgrade npm #14898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove downgrade npm close AUTH-345
|
can you add something to the PR description about why we need to remove downgrade? |
koji
requested review from
a team and
b-cooper
and removed request for
a team and
b-cooper
y3rsh
approved these changes
Apr 19, 2024
Carlos-fernandez
pushed a commit
that referenced
this pull request
May 20, 2024
* chore: remove downgrade npm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
remove downgrade npm
I added downgrade npm to handle workspace issue when updating electron version from 13 to 21.
#11537
Now we don't have any issues build on local / ci then we don't need to downgrade npm version anymore.
close AUTH-345
Test Plan
Changelog
Review requests
Risk assessment
low