chore(app-shell): Upgrade the Electron version to 21 #11537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge branch 'edge' into chore_update-electron-to-21
koji
requested review from
shlokamin,
mcous,
sfoster1 and
brenthagen
and removed request for
mcous,
sfoster1,
shlokamin and
brenthagen
|
Codecov Report
@@ Coverage Diff @@
## edge #11537 +/- ##
==========================================
- Coverage 75.00% 75.00% -0.01%
==========================================
Files 2057 2059 +2
Lines 57435 57446 +11
Branches 5985 5988 +3
==========================================
+ Hits 43079 43087 +8
- Misses 12949 12950 +1
- Partials 1407 1409 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…trons/opentrons into chore_update-electron-to-21
|
The .exe and .dmg work, connect to robots by USB and WiFi, and import custom labware. |
Oh, thank you for checking! |
Merge branch 'edge' into chore_update-electron-to-21
|
Merge branch 'edge' into chore_update-electron-to-21
…trons/opentrons into chore_update-electron-to-21
koji
removed
the
DO NOT MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This upgrade is for the ODD app. With Electron version 21, the ODD app works as expected (as well as the current app version). However, there are a couple of issues with this upgrade.
chore: overload deprecated AccessorSignatures nodejs/nan#943
-> The current solution is to use
patch-package. Oncenanissue is solved, we will remove this.nan maintainer merged the PR for this issue and the packages use
nanwill be updated the nan version.Once updates are done, we can remove this patch.
https://chromium.googlesource.com/v8/v8/+/8fd20298e5e9fdb69614ba37be1cba8930049dd9
node v16.8.0 can run
make -C app-shell dist-ot3without any errors.later versions need to run
CPPFLAGS="-std=c++17" make -C app-shell dist-ot3There are a couple of tasks for this update in the near future.
remove the patch
Once packages use
nanupdate it to the latest version, we will be able to remove patchupdate electron-builder (ideally without
alpha)Currently we need to use "24.0.0-alpha.1" for this issue.
Changelog
node-versionin workflows fromv14tov162019to2022for app-shell build./package.jsonto./app-shell/pakcage.jsonelectron.d.tsto extendFiletype the previous version of Electron addedpathtoFileReview requests
Risk assessment
medium
This PR will need Q&A team support since this change is related to the entire desktop app.