Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(app:) Capitalize 96 ch exit text #14840

Merged
merged 2 commits into from
Apr 9, 2024
Merged

style(app:) Capitalize 96 ch exit text #14840

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef51afa
style(app): capitalize "exit" in UnskippableModal
mjhuff Apr 8, 2024
3672328
pushing code with 5 minutes to work with is always smart
mjhuff Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/src/organisms/PipetteWizardFlows/UnskippableModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export function UnskippableModal(props: UnskippableModalProps): JSX.Element {
<SmallButton
marginRight={SPACING.spacing8}
onClick={proceed}
buttonText={t('shared:exit')}
buttonText={i18n.format(t('shared:exit'), 'capitalize')}
buttonType="alert"
disabled={isRobotMoving}
/>
Expand Down
4 changes: 3 additions & 1 deletion app/src/organisms/PipetteWizardFlows/__tests__/UnskippableModal.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ describe('UnskippableModal', () => {
screen.getByText(
'You must detach the mounting plate and reattach the z-axis carraige before using other pipettes. We do not recommend exiting this process before completion.'
)
fireEvent.click(screen.getByRole('button', { name: 'exit' }))
screen.getByText('Exit')
mjhuff marked this conversation as resolved.
Show resolved Hide resolved
screen.getByText('Go back')
fireEvent.click(screen.getByRole('button', { name: 'Exit' }))
expect(props.proceed).toHaveBeenCalled()
})
})
Loading