Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(app:) Capitalize 96 ch exit text #14840

Merged
merged 2 commits into from
Apr 9, 2024

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Apr 8, 2024

Overview

Capitalize 96 ch exit text during the attach flows.

image

Test Plan

  • Verify text is capitalized.

Risk assessment

low

@mjhuff mjhuff requested review from koji and a team April 8, 2024 22:24
@mjhuff mjhuff requested a review from a team as a code owner April 8, 2024 22:24
@mjhuff
Copy link
Contributor Author

mjhuff commented Apr 9, 2024

This is what I get for pushing a PR while walking out the door 😄

Copy link
Contributor

@koji koji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjhuff mjhuff merged commit b849a6a into chore_release-7.2.2 Apr 9, 2024
20 checks passed
@mjhuff mjhuff deleted the app_style-96-ch-exit-text branch April 9, 2024 02:30
@y3rsh y3rsh restored the app_style-96-ch-exit-text branch April 9, 2024 13:37
@y3rsh y3rsh mentioned this pull request Apr 9, 2024
mjhuff added a commit that referenced this pull request Apr 9, 2024
Into edge instead of release branch.

Was #14840

Co-authored-by: Jamey Huffnagle <[email protected]>
Carlos-fernandez pushed a commit that referenced this pull request May 20, 2024
Into edge instead of release branch.

Was #14840

Co-authored-by: Jamey Huffnagle <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants