Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app,components,shared-data): clean up deck config unused functions and types #14291

Merged
merged 19 commits into from
Jan 9, 2024

Merge branch 'edge' into components_deck-config-cleanup

4f8c071
Select commit
Loading
Failed to load commit list.
Merged

refactor(app,components,shared-data): clean up deck config unused functions and types #14291

Merge branch 'edge' into components_deck-config-cleanup
4f8c071
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 8, 2024 in 0s

27.50% of diff hit (target 68.08%)

View this Pull Request on Codecov

27.50% of diff hit (target 68.08%)

Annotations

Check warning on line 188 in components/src/hardware-sim/BaseDeck/BaseDeck.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/src/hardware-sim/BaseDeck/BaseDeck.tsx#L188

Added line #L188 was not covered by tests

Check warning on line 198 in components/src/hardware-sim/BaseDeck/BaseDeck.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/src/hardware-sim/BaseDeck/BaseDeck.tsx#L198

Added line #L198 was not covered by tests

Check warning on line 203 in components/src/hardware-sim/BaseDeck/BaseDeck.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/src/hardware-sim/BaseDeck/BaseDeck.tsx#L203

Added line #L203 was not covered by tests

Check warning on line 214 in components/src/hardware-sim/BaseDeck/BaseDeck.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/src/hardware-sim/BaseDeck/BaseDeck.tsx#L214

Added line #L214 was not covered by tests

Check warning on line 29 in components/src/hardware-sim/DeckConfigurator/StagingAreaConfigFixture.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/src/hardware-sim/DeckConfigurator/StagingAreaConfigFixture.tsx#L28-L29

Added lines #L28 - L29 were not covered by tests

Check warning on line 29 in components/src/hardware-sim/DeckConfigurator/TrashBinConfigFixture.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/src/hardware-sim/DeckConfigurator/TrashBinConfigFixture.tsx#L28-L29

Added lines #L28 - L29 were not covered by tests

Check warning on line 36 in components/src/hardware-sim/DeckConfigurator/WasteChuteConfigFixture.tsx

See this annotation in the file changed.

@codecov codecov / codecov/patch

components/src/hardware-sim/DeckConfigurator/WasteChuteConfigFixture.tsx#L35-L36

Added lines #L35 - L36 were not covered by tests

Check warning on line 286 in protocol-designer/src/file-data/selectors/fileCreator.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

protocol-designer/src/file-data/selectors/fileCreator.ts#L286

Added line #L286 was not covered by tests

Check warning on line 23 in shared-data/js/helpers/getAddressableAreasInProtocol.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

shared-data/js/helpers/getAddressableAreasInProtocol.ts#L23

Added line #L23 was not covered by tests

Check warning on line 29 in shared-data/js/helpers/getAddressableAreasInProtocol.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

shared-data/js/helpers/getAddressableAreasInProtocol.ts#L29

Added line #L29 was not covered by tests

Check warning on line 31 in shared-data/js/helpers/getAddressableAreasInProtocol.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

shared-data/js/helpers/getAddressableAreasInProtocol.ts#L31

Added line #L31 was not covered by tests

Check warning on line 68 in shared-data/js/helpers/getAddressableAreasInProtocol.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

shared-data/js/helpers/getAddressableAreasInProtocol.ts#L68

Added line #L68 was not covered by tests

Check warning on line 73 in shared-data/js/helpers/getAddressableAreasInProtocol.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

shared-data/js/helpers/getAddressableAreasInProtocol.ts#L73

Added line #L73 was not covered by tests

Check warning on line 78 in shared-data/js/helpers/getAddressableAreasInProtocol.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

shared-data/js/helpers/getAddressableAreasInProtocol.ts#L78

Added line #L78 was not covered by tests