Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(app,components,shared-data): clean up deck config unused functions and types #14291

Merged
merged 19 commits into from
Jan 9, 2024

Conversation

brenthagen
Copy link
Contributor

Overview

removes various unused utilities, components, and types related to deck config work. adds some test coverage. generally cleans up deck config TODOs.

closes RAUT-910

Test Plan

  • updated tests and types

Changelog

  • Cleans up deck config functions and types

Review requests

smoke test the app(s)

Risk assessment

low

@brenthagen brenthagen requested a review from a team January 5, 2024 19:44
@brenthagen brenthagen requested review from a team as code owners January 5, 2024 19:44
@brenthagen brenthagen requested review from koji and removed request for a team and koji January 5, 2024 19:44
Copy link

codecov bot commented Jan 5, 2024

Codecov Report

Attention: 29 lines in your changes are missing coverage. Please review.

Comparison is base (e627fca) 68.08% compared to head (4f8c071) 68.13%.
Report is 1 commits behind head on edge.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             edge   #14291      +/-   ##
==========================================
+ Coverage   68.08%   68.13%   +0.04%     
==========================================
  Files        2514     2512       -2     
  Lines       71459    71456       -3     
  Branches     9071     9072       +1     
==========================================
+ Hits        48654    48683      +29     
+ Misses      20693    20672      -21     
+ Partials     2112     2101      -11     
Flag Coverage Δ
app 65.53% <100.00%> (+0.15%) ⬆️
components 50.31% <8.69%> (-0.05%) ⬇️
labware-library 41.10% <ø> (ø)
protocol-designer 34.93% <50.00%> (ø)
react-api-client 65.73% <ø> (ø)
shared-data 75.12% <50.00%> (+0.06%) ⬆️
step-generation 86.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...CommandText/utils/getAddressableAreaDisplayName.ts 50.00% <100.00%> (ø)
...vices/ProtocolRun/SetupLiquids/SetupLiquidsMap.tsx 57.40% <ø> (ø)
...rotocolRun/SetupModuleAndDeck/SetupModulesList.tsx 82.35% <ø> (ø)
app/src/resources/deck_configuration/hooks.ts 73.68% <ø> (ø)
...onents/src/hardware-sim/Deck/MoveLabwareOnDeck.tsx 7.69% <ø> (ø)
...omponents/src/hardware-sim/Deck/RobotWorkSpace.tsx 33.33% <ø> (-3.04%) ⬇️
...gner/src/components/modules/AdditionalItemsRow.tsx 96.00% <ø> (ø)
...ol-designer/src/components/modules/FlexSlotMap.tsx 22.72% <ø> (ø)
...esigner/src/components/modules/StagingAreasRow.tsx 87.50% <100.00%> (ø)
protocol-designer/src/steplist/fieldLevel/index.ts 27.11% <ø> (ø)
... and 12 more

... and 8 files with indirect coverage changes

Copy link
Contributor

@b-cooper b-cooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 changes look good to me!

@brenthagen brenthagen merged commit f327ec9 into edge Jan 9, 2024
67 of 68 checks passed
@brenthagen brenthagen deleted the components_deck-config-cleanup branch January 9, 2024 15:44
mjhuff pushed a commit that referenced this pull request Jan 23, 2024
…ctions and types (#14291)

removes various unused utilities, components, and types related to deck config work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants