fix(protocol-engine): Fix hanging after cancellation #14215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes RQA-2091
Test Plan
Changelog
hardware_api.stop
before doing anything further with the hardware. This is the bug fix.Review requests
There are opportunities for further cleanup here. For example,
HardwareStopper._drop_tip()
is also stopping and homing, which makes the overall sequence hard to follow and seems outside of its responsibility.Since this PR has already been tested without that cleanup, let's not do it in this PR—but if you have any ideas, please do leave comments.
Risk assessment
Medium. I haven't looked at how well this code is covered by unit tests, but this PR is passing CI without having had to change anything, which suggests there are gaps.
Co-authored with @jbleon95 and @sfoster1