refactor(protocol-designer, step-generation): emit dropTipInPlace & m…

[jerader]

…oveToAddressableAreaForDropTip

Overview

I made a big oopsy and was only emitting moveToAddressableAreaForDropTip without the dropTipInPlace afterwards! Luckily, since those sequence of commands are consolidated in movableTrashCommandsUtil, it was an easy fix. I also had to update all the cypress migration tests again 🤦

Test Plan

Create a flex or ot-2 protocol in PD and drop tip into the trash bin. It can be a simple transfer/mix step. Download the protocol and upload it to the app. It should work in alpha.7 or the dev env built off of this branch. It should pass analysis.

Changelog

• emit dropTipInPlace in the movableTrashCommandsUtil and update the test
• delete now unnecessary robot state update fn for moveToAddressableAreaForDropTip
• fix cypress test fixtures

Review requests

see test plan

Risk assessment

low

[codecov]

Codecov Report

Merging #14203 (e41347e) into edge (ef15185) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

@@           Coverage Diff           @@
##             edge   #14203   +/-   ##
=======================================
  Coverage   70.38%   70.38%           
=======================================
  Files        2510     2510           
  Lines       71292    71292           
  Branches     9019     9019           
=======================================
  Hits        50179    50179           
  Misses      18901    18901           
  Partials     2212     2212           

Flag	Coverage Δ
protocol-designer	44.55% <ø> (ø)
step-generation	86.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
step-generation/src/fixtures/commandFixtures.ts	91.48% <ø> (ø)
...neration/src/getNextRobotStateAndWarnings/index.ts	72.85% <ø> (ø)

[koji]

Followed the test plan and it worked as expected. (OT-2/Flex both protocols passed analysis)