Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, api): expose failOnNotHomed parameter for save_position command #14139

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

mjhuff
Copy link
Contributor

@mjhuff mjhuff commented Dec 7, 2023

Overview

Drop tip flows require saving pipette positions without homing the plunger axis (we definitely do not want to home the plunger). The save_position command should optionally expose a failOnNotHomed parameter to prevent an error from being thrown when the plunger is not homed - the plunger position value is not stored in saved_position, anyway.

Test Plan

  • Run the drop tip wizard flows on a pipette such as the P300 8-Channel GEN2 and confirm via Network tab that the save position response is successful. NOTE: Drop tip flows will work on the OT-2 without a deckmap, just click Move to Slot - there's a default position.
  • Test the flows on a couple pipettes and Flex/OT-2 to confirm there aren't any unforeseen issues.

Changelog

  • The savePosition command now takes an optional failOnNotHomed boolean.

Risk assessment

low

Drop tip flows require saving pipette positions without homing the plunger axis (we definitely do
not want to home the plunger). The save_position command should optionally expose a failOnNotHomed
parameter to prevent an error from being thrown when the plunger is not homed.
@mjhuff mjhuff requested review from b-cooper, brenthagen and a team December 7, 2023 20:03
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #14139 (f7a24b8) into chore_release-7.1.0 (7e765eb) will decrease coverage by 0.02%.
Report is 1 commits behind head on chore_release-7.1.0.
The diff coverage is n/a.

❗ Current head f7a24b8 differs from pull request most recent head d81f663. Consider uploading reports for the commit d81f663 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14139      +/-   ##
=======================================================
- Coverage                70.44%   70.43%   -0.02%     
=======================================================
  Files                     2512     1636     -876     
  Lines                    71197    54482   -16715     
  Branches                  8962     4016    -4946     
=======================================================
- Hits                     50158    38372   -11786     
+ Misses                   18849    15416    -3433     
+ Partials                  2190      694    -1496     
Flag Coverage Δ
app 38.56% <ø> (-29.07%) ⬇️
notify-server 89.13% <ø> (ø)
protocol-designer 44.99% <ø> (ø)
shared-data 75.02% <ø> (ø)
step-generation 86.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...pentrons/protocol_engine/commands/save_position.py 100.00% <ø> (ø)

... and 877 files with indirect coverage changes

@mjhuff mjhuff force-pushed the app_api-save-position-fail-on-not-homed branch from 5e02ae5 to b5eeb4e Compare December 7, 2023 20:25
@mjhuff mjhuff removed the request for review from brenthagen December 7, 2023 20:29
@mjhuff mjhuff force-pushed the app_api-save-position-fail-on-not-homed branch from b5eeb4e to 9730c6b Compare December 7, 2023 20:49
@mjhuff mjhuff force-pushed the app_api-save-position-fail-on-not-homed branch from f7a24b8 to d81f663 Compare December 7, 2023 21:35
@mjhuff mjhuff marked this pull request as ready for review December 7, 2023 21:47
@mjhuff mjhuff requested review from a team as code owners December 7, 2023 21:47
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, nice work doing both sides!

@mjhuff mjhuff merged commit 7677f9a into chore_release-7.1.0 Dec 7, 2023
58 of 59 checks passed
@mjhuff mjhuff deleted the app_api-save-position-fail-on-not-homed branch December 7, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants