Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Remove experimental with_staging_area_slot_d4 parameter #14133

Merged
merged 2 commits into from
Dec 7, 2023

Conversation

SyntaxColoring
Copy link
Contributor

Overview

In #13828, I added a with_staging_area_slot_d4 parameter to ProtocolContext.load_waste_chute(). We ended up not needing it. So, remove it from the public Python Protocol API.

Test Plan

None needed.

Changelog

  • Remove the unused with_staging_area_slot_d4 parameter from ProtocolContext.load_waste_chute().
  • Also remove some constants from _waste_chute_dimensions that are unused now that we're pulling those positions from shared-data.

Review requests

None in particular.

Risk assessment

No risk.

@SyntaxColoring SyntaxColoring added api Affects the `api` project papi-v2 Python API V2 labels Dec 7, 2023
@SyntaxColoring SyntaxColoring requested a review from a team as a code owner December 7, 2023 17:39
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #14133 (2ee05ef) into chore_release-7.1.0 (72255ab) will decrease coverage by 0.35%.
Report is 6 commits behind head on chore_release-7.1.0.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##           chore_release-7.1.0   #14133      +/-   ##
=======================================================
- Coverage                70.44%   70.10%   -0.35%     
=======================================================
  Files                     2512     1637     -875     
  Lines                    71201    55396   -15805     
  Branches                  8964     4370    -4594     
=======================================================
- Hits                     50161    38833   -11328     
+ Misses                   18849    15821    -3028     
+ Partials                  2191      742    -1449     
Flag Coverage Δ
app 38.56% <ø> (-29.08%) ⬇️
components 59.96% <ø> (-0.09%) ⬇️
g-code-testing 96.44% <ø> (ø)
labware-library 51.50% <ø> (ø)
notify-server 89.13% <ø> (ø)
protocol-designer 45.19% <ø> (+0.19%) ⬆️
step-generation 86.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
api/src/opentrons/protocol_api/protocol_context.py 92.30% <ø> (ø)

... and 912 files with indirect coverage changes

@sanni-t
Copy link
Member

sanni-t commented Dec 7, 2023

Wait, I think you need to point this to chore_release_7.1.0?

@SyntaxColoring
Copy link
Contributor Author

🤦 Yes, thank you.

@SyntaxColoring SyntaxColoring requested a review from a team as a code owner December 7, 2023 22:12
@SyntaxColoring SyntaxColoring requested review from mjhuff and removed request for a team December 7, 2023 22:12
@SyntaxColoring SyntaxColoring changed the base branch from edge to chore_release-7.1.0 December 7, 2023 22:18
@SyntaxColoring SyntaxColoring merged commit b84c5ec into chore_release-7.1.0 Dec 7, 2023
59 checks passed
@SyntaxColoring SyntaxColoring deleted the cruft_b_gone branch December 7, 2023 22:20
@SyntaxColoring SyntaxColoring removed the request for review from mjhuff December 7, 2023 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Affects the `api` project papi-v2 Python API V2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants