Skip to content

Commit

Permalink
fix(api): Remove experimental with_staging_area_slot_d4 parameter (#…
Browse files Browse the repository at this point in the history
…14133)

* Delete unused stuff in _waste_chute_dimensions.
* Delete unused with_staging_area_slot_d4 arg.
  • Loading branch information
SyntaxColoring authored Dec 7, 2023
1 parent 281f88c commit b84c5ec
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 21 deletions.
6 changes: 0 additions & 6 deletions api/src/opentrons/protocol_api/_waste_chute.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,3 @@ class WasteChute:
See :py:obj:`ProtocolContext.load_waste_chute`.
"""

def __init__(
self,
with_staging_area_slot_d4: bool,
) -> None:
self._with_staging_area_slot_d4 = with_staging_area_slot_d4
9 changes: 1 addition & 8 deletions api/src/opentrons/protocol_api/_waste_chute_dimensions.py
Original file line number Diff line number Diff line change
@@ -1,18 +1,11 @@
"""Constants for the dimensions of the Flex waste chute.
TODO: These should be moved into shared-data and interpreted by Protocol Engine.
TODO: Delete this when we resolve https://opentrons.atlassian.net/browse/RSS-418.
"""


from opentrons.types import Point


SLOT_ORIGIN_TO_1_OR_8_TIP_A1 = Point(64, 21.91, 115)
SLOT_ORIGIN_TO_96_TIP_A1 = Point(14.445, 42.085, 115)

# TODO: This z-coord is misleading. We need to account for the labware height and the paddle height;
# we can't define this as a single coordinate.
SLOT_ORIGIN_TO_GRIPPER_JAW_CENTER = Point(64, 29, 136.5)

# This is the same with or without the cover attached, since the cover is flush with the rim.
ENVELOPE_HEIGHT = 125
8 changes: 1 addition & 7 deletions api/src/opentrons/protocol_api/protocol_context.py
Original file line number Diff line number Diff line change
Expand Up @@ -471,20 +471,14 @@ def load_trash_bin(self, location: DeckLocation) -> TrashBin:
@requires_version(2, 16)
def load_waste_chute(
self,
*,
with_staging_area_slot_d4: bool = False,
) -> WasteChute:
"""Load the waste chute on the deck.
The deck plate adapter for the waste chute can only go in slot D3. If you try to
load another item in slot D3 after loading the waste chute, or vice versa, the
API will raise an error.
"""
if with_staging_area_slot_d4:
raise NotImplementedError(
"The waste chute staging area slot is not currently implemented."
)
waste_chute = WasteChute(with_staging_area_slot_d4=with_staging_area_slot_d4)
waste_chute = WasteChute()
self._core.append_disposal_location(waste_chute)
return waste_chute

Expand Down

0 comments on commit b84c5ec

Please sign in to comment.