Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(app): add desktop and ODD droptip wizard loading/confirmation/errors on app #13815
feat(app): add desktop and ODD droptip wizard loading/confirmation/errors on app #13815
Changes from 10 commits
8eaf082
679b958
e87a3a0
6c1255c
510aaeb
83f41a8
a81b41a
6c61011
9bd45a0
4c84080
e7ff440
ce7d867
a503baf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 41 in app/src/organisms/DropTipWizard/BeforeBeginning.tsx
Codecov / codecov/patch
app/src/organisms/DropTipWizard/BeforeBeginning.tsx#L41
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason we aren't making use of GenericWizardTile here and in the other steps? I notice that these wizard steps have way more styling than step components in other flows (pipette, gripper, etc.). Maybe I'm missing something?
If this is something that actually needs refactoring but is time intensive, we can clean it up later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I completely overlooked the GenericWizardTile and was styling from scratch. I will refactor to make use of GenericWizardTile
Check warning on line 67 in app/src/organisms/DropTipWizard/BeforeBeginning.tsx
Codecov / codecov/patch
app/src/organisms/DropTipWizard/BeforeBeginning.tsx#L67
Check warning on line 78 in app/src/organisms/DropTipWizard/BeforeBeginning.tsx
Codecov / codecov/patch
app/src/organisms/DropTipWizard/BeforeBeginning.tsx#L78
Check warning on line 101 in app/src/organisms/DropTipWizard/BeforeBeginning.tsx
Codecov / codecov/patch
app/src/organisms/DropTipWizard/BeforeBeginning.tsx#L101
Check warning on line 52 in app/src/organisms/DropTipWizard/ChooseLocation.tsx
Codecov / codecov/patch
app/src/organisms/DropTipWizard/ChooseLocation.tsx#L51-L52
Check warning on line 82 in app/src/organisms/DropTipWizard/ChooseLocation.tsx
Codecov / codecov/patch
app/src/organisms/DropTipWizard/ChooseLocation.tsx#L80-L82
Check warning on line 87 in app/src/organisms/DropTipWizard/ChooseLocation.tsx
Codecov / codecov/patch
app/src/organisms/DropTipWizard/ChooseLocation.tsx#L87