feat(app): add desktop and ODD droptip wizard loading/confirmation/errors on app #13815
Conversation
Add loading, error, and confirmation states for all droptip wizard steps. Style tiles and add content for ODD and desktop.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## edge #13815 +/- ##
==========================================
- Coverage 70.75% 70.51% -0.25%
==========================================
Files 2465 2474 +9
Lines 69346 71605 +2259
Branches 8338 9220 +882
==========================================
+ Hits 49069 50495 +1426
- Misses 18317 18991 +674
- Partials 1960 2119 +159
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Having some difficulty with the flows:
- On Desktop - I'm stuck on the choose drop-tip location step. Clicking the confirm position doesn't cause the flow to proceed.
- On ODD - Choosing drop tip location doesn't move the gantry, and the jog controls don't appear to move the robot. I can click through all the way to "is the pipette positioned where the tips should be dropped?", but clicking drop tips doesn't do anything.
I'll look at the code once we get the functionality hammered out. Happy to pair some more if you want!
b-cooper
force-pushed
the
feat_droptip_wizard_loading_confirmation_errors
branch
from
88e4dc1 to
83f41a8
Compare
There was a problem hiding this comment.
Looks great, Nick! I added some cleanup/comments and considerations, but it works 🔥
Per Slack convo, outside of the gantry moving after blowout, I don't think we need to consider any functional changes (outside of the one padding issue).
Thanks for being patient with me trying to test this out!
| const handleProceed = (): void => { | ||
| handleCreateAndSetup(flowType === 'liquid_and_tips') | ||
| } | ||
|
|
||
| return ( | ||
| return isOnDevice ? ( |
There was a problem hiding this comment.
Is there any reason we aren't making use of GenericWizardTile here and in the other steps? I notice that these wizard steps have way more styling than step components in other flows (pipette, gripper, etc.). Maybe I'm missing something?
If this is something that actually needs refactoring but is time intensive, we can clean it up later.
There was a problem hiding this comment.
I completely overlooked the GenericWizardTile and was styling from scratch. I will refactor to make use of GenericWizardTile
closes RAUT-796
Overview
Adds functionality to Droptip Wizard, both on desktop and ODD. Handles loading, error, and confirmation states for robot gantry movement, blowout action, and tip drop action. Adds video assets for initial blowout/tip drop selection.
Test Plan
Review requests
@mjhuff (collaborator)
Risk assessment
medium