-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(app): copy QA from August 17 #13344
Merged
Merged
Changes from 8 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
64a902c
morning copy QA changes
ecormany f76b94a
afternoon copy QA changes
ecormany 84df90e
last batch o' QA
ecormany 7610427
lint
ecormany 973f87b
lpc split copy on device
b-cooper f31fa18
split tap and click text and test coverage
b-cooper f58ee1b
Merge branch 'chore_release-7.0.0' into copy-review-aug17
b-cooper 5824840
add space between sentences
b-cooper d4935c0
Merge branch 'chore_release-7.0.0' into copy-review-aug17
b-cooper 2406565
fix test and format
b-cooper 365a83a
Merge branch 'chore_release-7.0.0' into copy-review-aug17
ecormany bbc3df0
fix tests
koji File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -44,7 +44,7 @@ describe('OnDeviceDisplayAppFallback', () => { | |
const [{ getByText }] = render(props) | ||
getByText('An unknown error has occurred') | ||
getByText( | ||
'You need to restart your robot. Then download the robot logs from the Opentrons App and send them to [email protected] for assistance.' | ||
'You need to restart the touchscreen. Then download the robot logs from the Opentrons App and send them to [email protected] for assistance.' | ||
) | ||
getByText('Restart touchscreen') | ||
}) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,8 +33,8 @@ | |
"discovery_timeout": "Discovery timed out.", | ||
"download_update": "Download app update", | ||
"enable_dev_tools_description": "Enabling this setting opens Developer Tools on app launch, enables additional logging and gives access to feature flags.", | ||
"enable_dev_tools": "Enable Developer Tools", | ||
"error_boundary_description": "You need to restart your robot. Then download the robot logs from the Opentrons App and send them to [email protected] for assistance.", | ||
"enable_dev_tools": "Developer Tools", | ||
"error_boundary_description": "You need to restart the touchscreen. Then download the robot logs from the Opentrons App and send them to [email protected] for assistance.", | ||
"error_boundary_title": "An unknown error has occurred", | ||
"feature_flags": "Feature Flags", | ||
"general": "General", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,44 +1,44 @@ | ||
{ | ||
"are_you_sure_exit": "Are you sure you want to exit before completing {{flow}}?", | ||
"attach_gripper": "Attach Gripper", | ||
"attached_gripper_and_screw_in": "Attach the gripper to the robot by aligning the connector and ensuring a secure connection. Hold the gripper in place and use the hex screwdriver to tighten the gripper screws. Then test that the gripper is securely attached by gently pulling it side to side.", | ||
"attached_gripper_and_screw_in": "Attach the gripper to the robot by aligning the connector and pressing to ensure a secure connection. Hold the gripper in place. Tighten the top gripper screw first, and the bottom screw second. Then test that the gripper is securely attached by gently pulling it side to side.", | ||
"before_you_begin": "Before you begin", | ||
"begin_calibration": "Begin calibration", | ||
"calibrate_gripper": "Calibrate gripper", | ||
"calibrate_gripper": "Calibrate Gripper", | ||
"calibration_pin": "Calibration Pin", | ||
"complete_calibration": "Complete calibration", | ||
"connect_and_screw_in_gripper": "Connect and Screw In Gripper", | ||
"connect_and_screw_in_gripper": "Connect and secure gripper", | ||
"continue": "Continue", | ||
"continue_calibration": "Continue calibration", | ||
"detach_gripper": "Detach Gripper", | ||
"firmware_updating": "A firmware update is required, instrument is updating...", | ||
"get_started": "Get started", | ||
"gripper_calibration": "Gripper Calibration", | ||
"gripper_recalibration": "Gripper Recalibration", | ||
"gripper_still_attached": "Flex Gripper Still Attached", | ||
"gripper_successfully_attached_and_calibrated": "Flex Gripper Successfully Attached and Calibrated", | ||
"gripper_successfully_attached": "Flex Gripper Successfully Attached", | ||
"gripper_successfully_calibrated": "Flex Gripper Successfully Calibrated", | ||
"gripper_successfully_detached": "Flex Gripper Successfully Detached", | ||
"gripper_still_attached": "Flex Gripper still attached", | ||
"gripper_successfully_attached_and_calibrated": "Flex Gripper successfully attached and calibrated", | ||
"gripper_successfully_attached": "Gripper successfully attached", | ||
"gripper_successfully_calibrated": "Flex Gripper successfully calibrated", | ||
"gripper_successfully_detached": "Flex Gripper successfully detached", | ||
"gripper": "Gripper", | ||
"hex_screwdriver": "2.5 mm Hex Screwdriver", | ||
"hold_gripper_and_loosen_screws": "Hold the gripper in place and loosen the screws. (The screws are captive and will not come apart from the gripper) Then carefully remove the gripper", | ||
"insert_pin_into_front_jaw": "Insert Calibration Pin into Front Jaw", | ||
"insert_pin_into_rear_jaw": "Insert Calibration Pin into Rear Jaw", | ||
"loosen_screws_and_detach": "Loosen Screws and Detach", | ||
"hold_gripper_and_loosen_screws": "Hold the gripper in place and loosen the bottom gripper screw first. After that move onto the bottom screw. (The screws are captive and will not come apart from the gripper.) Then carefully remove the gripper.", | ||
"insert_pin_into_front_jaw": "Insert calibration pin in front jaw", | ||
"insert_pin_into_rear_jaw": "Insert calibration pin in rear jaw", | ||
"loosen_screws_and_detach": "Loosen screws and detach gripper", | ||
"move_gantry_to_front": "Move gantry to front", | ||
"move_pin_from_front_to_rear_jaw": "Remove the calibration pin from the front jaw and attach it to the similar location on the rear jaw", | ||
"move_pin_from_front_to_rear_jaw": "Remove the calibration pin from the front jaw and attach it to the rear jaw.", | ||
"move_pin_from_rear_jaw_to_storage": "Take the calibration pin from the rear gripper jaw and return it to its storage location.", | ||
"move_pin_from_storage_to_front_jaw": "Take the calibration pin from its storage location. Magnetically attach the pin to the hole on the underside of the front gripper jaw.", | ||
"please_retry_gripper_detach": "Please retry the detachment process to successfully detach the Gripper.", | ||
"progress_will_be_lost": "{{flow}} progress will be lost", | ||
"provided_with_robot_use_right_size": "Provided with robot. Using another size can strip the instrument’s screws.", | ||
"remove_calibration_pin": "Remove Calibration Pin", | ||
"remove_labware_to_get_started_attaching": "<block>To get started, remove labware from the rest of the deck and clean up the work area to make attachment and calibration easier. Also gather the needed equipment shown on the right hand side</block><block>The calibration pin is included with the gripper and should be stored on the exposed panel of the gripper.</block>", | ||
"remove_labware_to_get_started_detaching": "To get started, remove labware from the rest of the deck and clean up the work area to make attachment and calibration easier. Also gather the needed equipment shown on the right hand side", | ||
"remove_labware_to_get_started_recalibrating": "<block>To get started, remove labware from the rest of the deck and clean up the work area to make attachment and calibration easier. Also gather the needed equipment shown on the right hand side</block><block>The calibration pin is included with the gripper and should be stored on the exposed panel of the gripper.</block>", | ||
"remove_probe": "Unlatch the calibration probe, remove it from the pipette nozzle, and return it to its storage location.", | ||
"remove_calibration_pin": "Remove calibration pin", | ||
"remove_labware_to_get_started_attaching": "<block>To get started, remove labware from the deck and clean up the working area to make detachment easier. Also gather the needed equipment shown to the right.</block><block>The calibration pin is included with the gripper and should be stored on its right side above the jaws.</block>", | ||
"remove_labware_to_get_started_detaching": "To get started, remove labware from the deck and clean up the working area to make detachment easier. Also gather the needed equipment shown to the right.", | ||
"remove_labware_to_get_started_recalibrating": "<block>To get started, remove labware from the deck and clean up the working area to make detachment easier. Also gather the needed equipment shown to the right.</block><block>The calibration pin is included with the gripper and should be stored on its right side above the jaws.</block>", | ||
"remove_probe": "Unlock the calibration probe, remove it from the pipette nozzle, and return it to its storage location.", | ||
"return_pin_error": "<bold>Return the calibration pin to its storage location before exiting.</bold> <block>{{error}}</block>", | ||
"stand_back_gripper_is_calibrating": "Stand Back, Flex Gripper is Calibrating", | ||
"stand_back_gripper_is_calibrating": "Stand back, gripper is calibrating", | ||
"try_again": "Try again", | ||
"unable_to_detect_gripper": "Unable to detect Gripper" | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change has an impact on Desktop app.
Do we want to change Desktop app and Touchscreen app both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think that's good. I find settings that start with "Enable" to be redundant and harder to read.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, thanks!