fix(app): copy QA from August 17 #13344
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## chore_release-7.0.0 #13344 +/- ##
=======================================================
+ Coverage 71.30% 71.39% +0.09%
=======================================================
Files 2420 2418 -2
Lines 68076 67920 -156
Branches 7907 7899 -8
=======================================================
- Hits 48539 48489 -50
+ Misses 17685 17580 -105
+ Partials 1852 1851 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -14,8 +14,8 @@ | |||
| "confirm_position_and_move": "Confirm position, move to slot {{next_slot}}", | |||
| "confirm_position_and_pick_up_tip": "Confirm position, pick up tip", | |||
| "confirm_position_and_return_tip": "Confirm position, return tip to Slot {{next_slot}} and home", | |||
| "ensure_nozzle_is_above_tip": "Ensure that the pipette nozzle furthest from you is centered above and level with the top of the tip in the A1 position. If it isn't, use the controls below or your keyboard to jog the pipette until it is properly aligned.", | |||
| "ensure_tip_is_above_well": "Ensure that the pipette tip furthest from you is centered above and level with well A1 on the labware. If it isn't, use the controls below or your keyboard to jog the pipette until it is properly aligned.", | |||
| "ensure_nozzle_is_above_tip": "Ensure that the pipette nozzle furthest from you is centered above and level with the top of the tip in the A1 position. If it isn't, tap <bold>Move pipette</bold> and then jog the pipette until it is properly aligned.", | |||
There was a problem hiding this comment.
These might be trouble if they're shared between app and touchscreen. If so, refactor to use old text in app and new on touchscreen.
There was a problem hiding this comment.
These are shared between desktop and the touchscreen. We can add some branching logic so that the previous text shows on Desktop, and your new revision only shows on the Touchscreen if that's what you'd prefer?
| @@ -33,8 +33,8 @@ | |||
| "discovery_timeout": "Discovery timed out.", | |||
| "download_update": "Download app update", | |||
| "enable_dev_tools_description": "Enabling this setting opens Developer Tools on app launch, enables additional logging and gives access to feature flags.", | |||
| "enable_dev_tools": "Enable Developer Tools", | |||
| "error_boundary_description": "You need to restart your robot. Then download the robot logs from the Opentrons App and send them to [email protected] for assistance.", | |||
| "enable_dev_tools": "Developer Tools", | |||
There was a problem hiding this comment.
This change has an impact on Desktop app.
Do we want to change Desktop app and Touchscreen app both?
There was a problem hiding this comment.
Yes, I think that's good. I find settings that start with "Enable" to be redundant and harder to read.
|
@ecormany |
Overview
This PR contains a number of localization changes (and corresponding tests) found in a copy QA session done on Flex hardware on August 17. The goal is to have in-app copy match designs in Figma as exactly as possible (without significant refactoring for very small gains, like capitalization only).
The changes here are strings that I could easily find and was reasonably confident only applied to the screens we were looking at on-device. Some more complicated changes that may require refactoring will be ticketed separately.
Partially addresses RUXD-1061.
Test Plan
Check that these strings render properly in the touchscreen app.
We've already verified the new text against what's in Figma.
Changelog
Review requests
Risk assessment
Low. This barely touches code, but there's always the possibility of breaking an interface element or otherwise worsening the user experience.