fix(app): fix failed error details modal styling and long protocol me display issue #13133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me display update the box width for a case that an error is very short. change overflow-wrap from break-word to anywhere. RAUT-
Codecov Report
@@ Coverage Diff @@
## edge #13133 +/- ##
==========================================
- Coverage 72.47% 72.46% -0.02%
==========================================
Files 2353 2355 +2
Lines 64902 65047 +145
Branches 7188 7259 +71
==========================================
+ Hits 47040 47135 +95
- Misses 16123 16143 +20
- Partials 1739 1769 +30
Flags with carried forward coverage won't be shown. Click here to find out more.
|
koji
requested review from
TamarZanzouri
and removed request for
a team and
TamarZanzouri
koji
commented
Jul 20, 2023
Comment on lines
494
to
495
| (protocolHasModules && attachedModules.length === 0) || | ||
| allPipettesCalibrationData.data.length === 0 |
There was a problem hiding this comment.
allPipettesCalibrationData is object
{
data(array)
links
}
In my understanding, this disabled is true if there is no calibration data. We need to check the length of allPipettesCalibrationData.data
There was a problem hiding this comment.
This will be fixed in a following PR
brenthagen
reviewed
Jul 21, 2023
| @@ -50,7 +50,6 @@ export function OnDeviceDisplayAppFallback({ | |||
| return ( | |||
| <Modal header={modalHeader}> | |||
There was a problem hiding this comment.
header needs iconColor: COLORS.red2
brenthagen
approved these changes
Jul 21, 2023
koji
deleted the
fix_failed-view-details-modal-box-size-and-plus_alpha
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, users can call the function when tapping the button.
RunSummary View Error Details Modal
before
after
ProtocolDetails page
before
after
close RAUT-573
Test Plan
Check the play button in ProtocolSetup screen doesn't do anything.
Changelog
Review requests
Risk assessment