Skip to content

Commit

Permalink
fix(app): fix failed error details modal styling and long protocol me…
Browse files Browse the repository at this point in the history
… display issue (#13133)

* fix(app): fix failed error details modal styling and long protocol name display
  • Loading branch information
koji authored Jul 21, 2023
1 parent e1da55c commit 159ec95
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 5 deletions.
3 changes: 1 addition & 2 deletions app/src/App/OnDeviceDisplayAppFallback.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export function OnDeviceDisplayAppFallback({
const modalHeader: ModalHeaderBaseProps = {
title: t('error_boundary_title'),
iconName: 'information',
iconColor: COLORS.white,
iconColor: COLORS.red2,
}

// immediately report to robot logs that something fatal happened
Expand All @@ -50,7 +50,6 @@ export function OnDeviceDisplayAppFallback({
return (
<Modal header={modalHeader}>
<Flex
marginTop={SPACING.spacing32}
flexDirection={DIRECTION_COLUMN}
gridGap={SPACING.spacing32}
alignItems={ALIGN_CENTER}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ const TITLE_TEXT_STYLE = css`
-webkit-box-orient: vertical;
-webkit-line-clamp: 2;
overflow: hidden;
overflow-wrap: break-word;
overflow-wrap: anywhere;
height: max-content;
`

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ export function RunFailedModal({
})}
</StyledText>
<Flex
width="100%"
flexDirection={DIRECTION_COLUMN}
gridGap={SPACING.spacing8}
maxHeight="11rem"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ const TITLE_TEXT_STYLE = css`
-webkit-box-orient: vertical;
-webkit-line-clamp: 2;
overflow: hidden;
overflow-wrap: break-word;
overflow-wrap: anywhere;
height: max-content;
`

Expand Down
1 change: 1 addition & 0 deletions app/src/organisms/ProtocolDetails/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,7 @@ export function ProtocolDetails(
css={TYPOGRAPHY.h2SemiBold}
marginBottom={SPACING.spacing16}
data-testid={`ProtocolDetails_${protocolDisplayName}`}
overflowWrap="anywhere"
>
{protocolDisplayName}
</StyledText>
Expand Down
2 changes: 1 addition & 1 deletion app/src/pages/OnDeviceDisplay/RunSummary.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -330,7 +330,7 @@ const ProtocolName = styled.h4`
-webkit-box-orient: vertical;
-webkit-line-clamp: 2;
overflow: hidden;
overflow-wrap: break-word;
overflow-wrap: anywhere;
height: max-content;
`

Expand Down

0 comments on commit 159ec95

Please sign in to comment.