Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): separate home and backoff steps into separate move groups #13095

Merged
merged 5 commits into from
Jul 13, 2023
+147 −158
Merged

fix(api): separate home and backoff steps into separate move groups #13095

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d4fe0b7
separate home and backoff to two different groups
ahiuchingau Jul 11, 2023
a6721e7
fix func
ahiuchingau Jul 12, 2023
feb4230
update controller tests
ahiuchingau Jul 12, 2023
f3bb7ff
fix lint
ahiuchingau Jul 12, 2023
79922d7
fix more lint
ahiuchingau Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix lint
@ahiuchingau
ahiuchingau committed Jul 13, 2023

Verified

This commit was signed with the committer’s verified signature.
TimoGlastra Timo Glastra
GPG key ID: 2369AB20203EAA49
Verified
Learn about vigilant mode
commit f3bb7ff91675d98605ba1526ad3890f1a65652b8
6 changes: 4 additions & 2 deletions api/tests/opentrons/hardware_control/backends/test_ot3_controller.py
View file
Original file line number Diff line number Diff line change
@@ -308,7 +308,7 @@ async def test_home_execute(
mock_present_devices: None,
) -> None:
config = {"run.side_effect": move_group_run_side_effect(controller, axes)}
with mock.patch(
with mock.patch( # type: ignore [call-overload]
"opentrons.hardware_control.backends.ot3controller.MoveGroupRunner",
spec=mock.Mock(MoveGroupRunner),
**config
@@ -325,7 +325,9 @@ async def test_home_execute(
for group in arg.kwargs["move_groups"]
]

actual_nodes_steps = {ax: [] for ax in axes}
actual_nodes_steps: Dict[OT3Axis, List[MoveGroupSingleAxisStep]] = {
ax: [] for ax in axes
}
for group in all_groups:
for step in group:
for k, v in step.items():