chore(build): fix push targets in api and s-d #11879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These push targets in the makefiles in these projects were using the wheel and sdist filenames as target dependencies, but there was no longer a pattern target that matched them.
Laura-Danielle
approved these changes
Dec 13, 2022
TamarZanzouri
approved these changes
Dec 13, 2022
Codecov Report
@@ Coverage Diff @@
## edge #11879 +/- ##
=======================================
Coverage 74.35% 74.35%
=======================================
Files 2150 2150
Lines 59414 59414
Branches 6237 6237
=======================================
Hits 44176 44176
Misses 13768 13768
Partials 1470 1470
Flags with carried forward coverage won't be shown. Click here to find out more. |
y3rsh
added a commit
that referenced
this pull request
Dec 14, 2022
* origin/edge: fix(api): ot3controller should utilize `check_ready_for_movement` (#11752) chore(docs): updating Google Tag Manager on docs subdomain #11855 refactor(app): add gripper attach, detach, and calibrate user-flow logic and skeletons (#11826) chore(build): fix push targets in api and s-d (#11879) fix(app): moveToLocation should be moveToMaintenancePosition (#11878) refactor(api): implement new Deck dependencies (#11853) refactor(api): implement new Deck collaborations (#11844) feat(app): create modals and add steps for 96 channel attach and detach (#11815) chore(build): Derive application versions from git (#11863) refactor(api): add support for Well.has_tip to the engine core (#11870) refactor(app, shared-data): calibration/moveToLocation to calibration/moveToMaintenancePosition (#11849) test(engine): add missing module_view test (#11872)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These push targets in the makefiles in these projects were using the wheel and sdist filenames as target dependencies, but there was no longer a pattern target that matched them.