feat(app): create modals and add steps for 96 channel attach and detach #11815
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## edge #11815 +/- ##
==========================================
+ Coverage 74.25% 74.34% +0.09%
==========================================
Files 2111 2123 +12
Lines 58767 59039 +272
Branches 6237 6261 +24
==========================================
+ Hits 43635 43893 +258
- Misses 13657 13670 +13
- Partials 1475 1476 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jerader
force-pushed
the
app_create_modals_for_96_channel
branch
from
07e9a8c to
b34a52e
Compare
jerader
requested review from
mcous,
smb2268 and
a team
and removed request for
a team and
mcous
smb2268
approved these changes
Dec 13, 2022
| HEX_SCREWDRIVER, | ||
| NINETY_SIX_CHANNEL_MOUNTING_PLATE, | ||
| ] | ||
| } |
There was a problem hiding this comment.
The BeforeBeginning screen is scrolling with 4 items in the equipment list, maybe we should give this modal a minHeight so the button is always visible
smb2268
reviewed
Dec 13, 2022
| { section: SECTIONS.DETACH_PIPETTE, mount: mount, flowType: flowType }, | ||
| { section: SECTIONS.RESULTS, mount: mount, flowType: flowType }, | ||
| ] | ||
| } else if (selectedPipette === NINETY_SIX_CHANNEL) { |
There was a problem hiding this comment.
For all 96-channel cases, let's hard code LEFT as the mount. Regardless of which pipette card the user selected, it'll be on both mounts but we'll send commands to the left one.
y3rsh
added a commit
that referenced
this pull request
Dec 14, 2022
* origin/edge: fix(api): ot3controller should utilize `check_ready_for_movement` (#11752) chore(docs): updating Google Tag Manager on docs subdomain #11855 refactor(app): add gripper attach, detach, and calibrate user-flow logic and skeletons (#11826) chore(build): fix push targets in api and s-d (#11879) fix(app): moveToLocation should be moveToMaintenancePosition (#11878) refactor(api): implement new Deck dependencies (#11853) refactor(api): implement new Deck collaborations (#11844) feat(app): create modals and add steps for 96 channel attach and detach (#11815) chore(build): Derive application versions from git (#11863) refactor(api): add support for Well.has_tip to the engine core (#11870) refactor(app, shared-data): calibration/moveToLocation to calibration/moveToMaintenancePosition (#11849) test(engine): add missing module_view test (#11872)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes RLIQ-264 and RLIQ-263
Overview
This PR creates the modals for all steps in the attach and detach 96 channel pipette flow and hooks them up to the parent component
PipetteWizardFlows. Commands are not wired up yet.Changelog
equipmentListCarriageandMountingPlatethat is used for both attach and detach flowsgetPipetteWizardFlows, with the 2 new sections calledCARRIAGEandMOUNTING_PLATE, adds to testPipetteWizardStepPropsto includeSelectedPipetteto tell if the pipette to attach/detach/cal is 96 channel or single mountPipetteCardso the flows can be accessed there.Review requests
Risk assessment
low