Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(python): remove line length limit from flake8 config #10695

Merged
merged 1 commit into from
Jun 9, 2022

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Jun 9, 2022

Overview

Closes #9931. See ticket for more details. Decided to tackle this now to ease onboarding of new Python contributors by removing useless busywork.

Changelog

  • style(python): remove line length limit from flake8 config

Review requests

  • Your local editor handles these config changes
    • Note: if your editor does not hook into flake8, you may need to change some settings manually to ignore E501
  • Your local make lint handles these config changes
  • CI handles these config changes

Risk assessment

Low due to the nature of the change (lint config + comment removal). When you're skimming the diff, make sure you only see removals of noqa: E501 in the diff.

@mcous mcous added the robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). label Jun 9, 2022
@mcous mcous requested review from a team as code owners June 9, 2022 14:43
@codecov
Copy link

codecov bot commented Jun 9, 2022

Codecov Report

Merging #10695 (d12d651) into edge (93249af) will not change coverage.
The diff coverage is 96.15%.

Impacted file tree graph

@@           Coverage Diff           @@
##             edge   #10695   +/-   ##
=======================================
  Coverage   73.82%   73.82%           
=======================================
  Files        2152     2152           
  Lines       58225    58225           
  Branches     5960     5960           
=======================================
  Hits        42983    42983           
  Misses      13969    13969           
  Partials     1273     1273           
Flag Coverage Δ
app 71.58% <ø> (ø)
g-code-testing 97.13% <100.00%> (ø)
hardware 59.21% <66.66%> (ø)
notify-server 89.17% <ø> (ø)
protocol-designer 45.69% <ø> (ø)
shared-data 85.38% <ø> (ø)
step-generation 86.83% <ø> (ø)
update-server 72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
api/src/opentrons/calibration_storage/modify.py 74.10% <ø> (ø)
...c/opentrons/drivers/smoothie_drivers/driver_3_0.py 80.74% <ø> (ø)
...i/src/opentrons/protocol_api/instrument_context.py 88.66% <ø> (ø)
...rc/opentrons/protocol_reader/file_reader_writer.py 100.00% <ø> (ø)
...protocols/context/protocol_api/protocol_context.py 92.50% <ø> (ø)
...ns/protocols/context/simulator/protocol_context.py 100.00% <ø> (ø)
.../opentrons/protocols/execution/json_dispatchers.py 91.66% <ø> (ø)
api/src/opentrons/protocols/types.py 91.11% <ø> (ø)
api/src/opentrons/simulate.py 64.16% <0.00%> (ø)
api/src/opentrons/system/camera.py 0.00% <0.00%> (ø)
... and 80 more

Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My goodness, it's beautiful

@mcous mcous merged commit 0e29be3 into edge Jun 9, 2022
@mcous mcous deleted the python_remove-flake8-line-limit branch June 9, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: disable E501 (line length) in Python linting
2 participants