Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: disable E501 (line length) in Python linting #9931

Closed
mcous opened this issue Apr 11, 2022 · 0 comments · Fixed by #10695
Closed

chore: disable E501 (line length) in Python linting #9931

mcous opened this issue Apr 11, 2022 · 0 comments · Fixed by #10695
Labels
api Affects the `api` project python General Python tickets and PRs; e.g. tech debt or Python guild activities robot server Affects the `robot-server` project Robot Tech Debt For review in robot guild meetings robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). shared data Affects the `shared-data` project

Comments

@mcous
Copy link
Contributor

mcous commented Apr 11, 2022

Overview

Since we've introduced black to format our Python code, Flake8's line length errors mostly just introduces busywork rather than actively improve the code style and readability.

After a quick, non-scientific poll of @Opentrons/py, we think we should remove the line-length error from Flake8 entirely and let Black do what it wants to do
@mcous mcous added robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). Robot Tech Debt For review in robot guild meetings labels Apr 11, 2022
@mcous mcous mentioned this issue Apr 11, 2022
Merged
@SyntaxColoring SyntaxColoring added api Affects the `api` project shared data Affects the `shared-data` project robot server Affects the `robot-server` project python General Python tickets and PRs; e.g. tech debt or Python guild activities labels Apr 11, 2022
mcous added a commit that referenced this issue Jun 9, 2022
@mcous
style(python): remove line length limit from flake8 config
d12d651 
Closes #9931
@mcous mcous mentioned this issue Jun 9, 2022
Merged
3 tasks
mcous added a commit that referenced this issue Jun 9, 2022
@mcous
style(python): remove line length limit from flake8 config (#10695)
0e29be3 
Closes #9931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Affects the `api` project python General Python tickets and PRs; e.g. tech debt or Python guild activities robot server Affects the `robot-server` project Robot Tech Debt For review in robot guild meetings robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). shared data Affects the `shared-data` project
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(python): remove line length limit from flake8 config Opentrons/opentrons
2 participants
@mcous @SyntaxColoring