-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(hardware): replace pytest-aiohttp with pytest-asyncio #10022
Conversation
Codecov Report
@@ Coverage Diff @@
## edge #10022 +/- ##
=======================================
Coverage 75.00% 75.01%
=======================================
Files 2086 2086
Lines 54977 54977
Branches 5568 5568
=======================================
+ Hits 41234 41239 +5
+ Misses 12631 12626 -5
Partials 1112 1112
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes make sense to me, and running make -C hardware test
works. 🧪 I'm not sure how make test-with-emulator
works, so I couldn't verify that.
I verified |
Looks like there's a hanging test:
😬 |
I am merging this PR, because the hanging test issue is in |
Overview
Just like #10012 and #9981 we should replace pytest-aiohttp with pytest-asyncio. It's faster.
Changelog
Review requests
Risk assessment
None