Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(robot-server): replace pytest-aiohttp with pytest-asyncio #10012

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Apr 19, 2022

Overview

robot-server follow-up for #9981. Less important / impactful than that PR, but still important to unblock some dev environment improvements that are a little bit blocked by the fact that various dev environments pull in aiohttp completely unnecessarily.

That being said, still seeing a non-trivial test suite speedup:

  • This PR: 1m39s
  • edge: 2m21s

Changelog

  • test(robot-server): replace pytest-aiohttp with pytest-asyncio

Review requests

Risk assessment

Low risk to production, test-only changes. Risk is to DX, since we could be unintentionally adding flakiness to our test suite locally and in CI. However, if things go well, this is a DX improvement.

@mcous mcous added robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience). Robot Tech Debt For review in robot guild meetings labels Apr 19, 2022
@mcous mcous requested review from a team as code owners April 19, 2022 20:54
Copy link
Contributor

@amitlissack amitlissack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Robot Tech Debt For review in robot guild meetings robot-svcs Falls under the purview of the Robot Services squad (formerly CPX, Core Platform Experience).
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants