Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectable Tipracks: Add the ability to select a tiprack for pipette offset calibration #7087

Closed
sfoster1 opened this issue Dec 2, 2020 · 0 comments · Fixed by #7155
Closed
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature

Comments

@sfoster1
Copy link
Member

sfoster1 commented Dec 2, 2020

Using the data in #7085 and the components in #7086, implement the ability to select a tiprack for pipette offset. This selection does not have to be saved.

The selection should

This ability should only be allowed from the pipette-offset-calibration intent, i.e. a user calibrating a pipette during attach; clicking calibrate offset in the instrument settings panel; or clicking recalibrate offset. For the tip length intents, this should not be displayed, since the tip rack to use is implied.

@sfoster1 sfoster1 added app Affects the `app` project feature Ticket is a feature request / PR introduces a feature labels Dec 2, 2020
ahiuchingau added a commit that referenced this issue Jan 5, 2021
…t cal (#7155)

* feat(app): allow custom tiprack selection in deck cal & pipette offset cal

closes #7087

* link choose tiprack screen in intro

* render selected tiprack in intro screen

* add uri param to tip len cal and new selector

* add recalibrate pip offset intent

* fix flow & test errors

* reformat intro screen continue button

* add tests

* fix css lint error

* add cancel button

* conditionally show dropdown labels

* warn about override tip length cal in tlc

* show previously chosen tiprack as default

* use pip offset tiprack hash to check tip length data

* match selector-class-pattern

* fix broken tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant