You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I think the app should send name: null, but there's also a chance it should send name: "", or even not send a name at all. I haven't had a chance to look deeply into Intercom's user attribute semantics.
The text was updated successfully, but these errors were encountered:
As a quick partial fix, I've changed the Intercom chat box welcome message to "Hi there! 👋", ignoring the user's name.
Leaving this issue open because:
The user's name is used in several other places throughout Intercom, and I don't think we'll always remember to account for this problem in each place.
In the absence of a known name or email, Intercom will display that user id in the inbound panel as the users name, which felt annoying at the time
The downsides of assigning the literal "Unknown User" to the name (e.g. having working fallbacks for an unknown name in automatic messages) seem to pretty clearly outweigh the downsides that lead us to implement Unknown User in the first place, but we should be aware that removing the default name will cause UUIDs to be displayed at the users' names on our end
Overview
Intercom has a few places that identify users by first name. ("Hi, Max!")
It has smart fallbacks for when it doesn't know the user's name. ("Hi, there!")
The app accidentally circumvents those fallbacks by setting the user's full name to "Unknown User":
Steps to reproduce
Application Support/Opentrons
.)Current behavior
The app sends this to Intercom upon first contact:
opentrons/app-shell/src/config/migrate.js
Line 66 in 1886fd1
Expected behavior
I think the app should send
name: null
, but there's also a chance it should sendname: ""
, or even not send aname
at all. I haven't had a chance to look deeply into Intercom's user attribute semantics.The text was updated successfully, but these errors were encountered: