Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: App tells Intercom that unknown users are literally named "Unknown User" #6461

Closed
SyntaxColoring opened this issue Sep 1, 2020 · 2 comments · Fixed by #6468
Closed
Labels
app Affects the `app` project bug

Comments

@SyntaxColoring
Copy link
Contributor

SyntaxColoring commented Sep 1, 2020

Overview

  • Intercom has a few places that identify users by first name. ("Hi, Max!")

  • It has smart fallbacks for when it doesn't know the user's name. ("Hi, there!")

  • The app accidentally circumvents those fallbacks by setting the user's full name to "Unknown User":

    Screen Shot 2020-09-01 at 10 16 16 AM Screen Shot 2020-09-01 at 10 17 28 AM

Steps to reproduce

  1. Get a totally fresh Opentrons App installation. (You'll probably need to delete Application Support/Opentrons.)
  2. Open a chat.
  3. On Intercom, see that this is how you're identified:

Screen Shot 2020-09-01 at 10 21 57 AM

Current behavior

The app sends this to Intercom upon first contact:

name: 'Unknown User',

Expected behavior

I think the app should send name: null, but there's also a chance it should send name: "", or even not send a name at all. I haven't had a chance to look deeply into Intercom's user attribute semantics.

@SyntaxColoring SyntaxColoring added bug app Affects the `app` project labels Sep 1, 2020
@SyntaxColoring
Copy link
Contributor Author

SyntaxColoring commented Sep 1, 2020

As a quick partial fix, I've changed the Intercom chat box welcome message to "Hi there! 👋", ignoring the user's name.

Leaving this issue open because:

  • The user's name is used in several other places throughout Intercom, and I don't think we'll always remember to account for this problem in each place.
  • Data hygiene is desirable in itself.

@mcous
Copy link
Contributor

mcous commented Sep 1, 2020

This was an intentional decision to address the following:

Screen Shot 2020-09-01 at 13 25 04

The downsides of assigning the literal "Unknown User" to the name (e.g. having working fallbacks for an unknown name in automatic messages) seem to pretty clearly outweigh the downsides that lead us to implement Unknown User in the first place, but we should be aware that removing the default name will cause UUIDs to be displayed at the users' names on our end

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants