Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App: show and proceed with available module updates #4576

Closed
b-cooper opened this issue Dec 10, 2019 · 1 comment · Fixed by #4889 or #4923
Closed

App: show and proceed with available module updates #4576

b-cooper opened this issue Dec 10, 2019 · 1 comment · Fixed by #4889 or #4923
Assignees
@b-cooper
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature hmg hardware, motion, and geometry
Milestone
HMG Sprint 2

Comments

@b-cooper
Copy link
Contributor

overview

This provides the front-end changes to #4575.
The currently designed "Updated" button in the Modules & Pipettes tab should suffice for an initial UI.

In the GET /modules response, parse out whether or not there is an available update for a given module by serial number. If there is, enable the button and change its text to "Update".

Upon clicking, show some loading state (preferrably one that states "keep module plugged in and turned on"), and display the module update response.
@b-cooper b-cooper added app Affects the `app` project feature Ticket is a feature request / PR introduces a feature labels Dec 10, 2019
@b-cooper b-cooper self-assigned this Dec 10, 2019
@b-cooper b-cooper mentioned this issue Dec 9, 2019
Closed
@mcous
Copy link
Contributor

mcous commented Dec 10, 2019

Heads up: I'm planning to refactor the modules state in the app to follow the latest stuff in the cookbooks (see #4440 and #4573 for the same refactor with pipettes, and #4477 for the same refactor for config reset and restart).

Might make sense to knock the refactor out to avoid duplication of work and to hopefully make the implementation of this feature more straightforward; the modules actions and reducer will be more simple after the refactor

@mcous mcous mentioned this issue Dec 16, 2019
Merged
3 tasks
@sfoster1 sfoster1 added the hmg hardware, motion, and geometry label Jan 17, 2020
@b-cooper b-cooper mentioned this issue Jan 17, 2020
Merged
2 tasks
b-cooper added a commit that referenced this issue Jan 29, 2020
@b-cooper
feat(api): add perform module fw update endpoint
4abf8a9 
Add ability to initiate a module fw update for a given attached module, referenced by its serial
number via http. Remove old unused module os level configuration. Update the module update machinery
and comments to be more accurate and generic.

Closes #4576
@b-cooper b-cooper mentioned this issue Jan 29, 2020
Merged
@sfoster1 sfoster1 added this to the HMG Sprint 2 milestone Feb 3, 2020
b-cooper added a commit that referenced this issue Feb 5, 2020
@b-cooper
feat(api): add perform module fw update endpoint (#4889)
5354eff 
Add ability to initiate a module fw update for a given attached module, referenced by its serial
number via http. Remove old unused module os level configuration. Update the module update machinery and comments to be more accurate and generic.

Closes #4576
b-cooper added a commit that referenced this issue Feb 5, 2020
@b-cooper
feat(api): add perform module fw update endpoint
ad3e756 
Add ability to initiate a module fw update for a given attached module, referenced by its serial
number via http. Remove old unused module os level configuration. Update the module update machinery
and comments to be more accurate and generic.

Closes #4576
b-cooper added a commit that referenced this issue Feb 5, 2020
@b-cooper
feat(app): enable module firmware update button when update available
f72543f 
Building on previous work to get the newest module fw on the robot per each release, this adds
functionality to the app allowing the user to update an attached module of their connected robot, if
that module has an available firmware update.

re #4576, Closes #4575
b-cooper added a commit that referenced this issue Feb 5, 2020
@b-cooper
feat(app): enable module firmware update button when update available
fb1c060 
Building on previous work to get the newest module fw on the robot per each release, this adds
functionality to the app allowing the user to update an attached module of their connected robot, if
that module has an available firmware update.

re #4576, Closes #4575
@b-cooper b-cooper mentioned this issue Feb 5, 2020
Merged
5 tasks
b-cooper added a commit that referenced this issue Feb 7, 2020
@b-cooper
feat(app): enable module firmware update button when update available (…
1edc587 
…#4923)

Building on previous work to get the newest module fw on the robot per each release, this adds
functionality to the app allowing the user to update an attached module of their connected robot, if that module has an available firmware update.

re #4576, Closes #4575
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@b-cooper b-cooper

Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature hmg hardware, motion, and geometry
Projects
None yet
Milestone
HMG Sprint 2
3 participants
@mcous @sfoster1 @b-cooper