Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app): add simple aggregate event tracking for custom labware #4544

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

mcous
Copy link
Contributor

@mcous mcous commented Dec 4, 2019

overview

This PR adds analytics events for various custom labware actions. Closes #4537

changelog

  • feat(app): add simple agregate event tracking for custom labware

review requests

Pretty well covered by unit tests, but if you feel so inclined:

  1. Set MIXPANEL_ID to our test application ID
  2. Do various custom labware stuff
  3. Observe actions

See original ticket for link to events specs

@mcous mcous added feature Ticket is a feature request / PR introduces a feature app Affects the `app` project ready for review labels Dec 4, 2019
@mcous mcous requested review from umbhau and a team December 4, 2019 21:52
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, watched analytics events go through

@codecov
Copy link

codecov bot commented Dec 4, 2019

Codecov Report

Merging #4544 into release_3.15.0 will increase coverage by 0.23%.
The diff coverage is 90.69%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release_3.15.0    #4544      +/-   ##
==================================================
+ Coverage           57.13%   57.36%   +0.23%     
==================================================
  Files                 905      906       +1     
  Lines               25711    25883     +172     
==================================================
+ Hits                14690    14849     +159     
- Misses              11021    11034      +13
Impacted Files Coverage Δ
app/src/analytics/epics.js 100% <ø> (ø) ⬆️
app/src/analytics/mixpanel.js 13.04% <0%> (-1.25%) ⬇️
app/src/components/AddLabwareCard/index.js 100% <100%> (ø) ⬆️
app/src/components/layout/CardCopy.js 100% <100%> (ø)
app-shell/src/labware/index.js 100% <100%> (ø) ⬆️
app/src/custom-labware/actions.js 100% <100%> (ø) ⬆️
app/src/analytics/make-event.js 72.13% <95.83%> (+15.37%) ⬆️
app/src/protocol/index.js 100% <0%> (ø) ⬆️
opentrons/protocol_api/labware.py 90.51% <0%> (+0.37%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9023d95...e28d305. Read the comment docs.

@sfoster1 sfoster1 changed the title feat(app): add simple agregate event tracking for custom labware feat(app): add simple aggregate event tracking for custom labware Dec 5, 2019
Copy link
Member

@sfoster1 sfoster1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also checked out the copy change, LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app Affects the `app` project feature Ticket is a feature request / PR introduces a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants