Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): separate home and backoff steps into separate move groups #13095

Merged
merged 5 commits into from
Jul 13, 2023

Conversation

ahiuchingau
Copy link
Contributor

Overview

Since the limit switch and backoff moves are in the same move group, the node will immediately execute the backoff move upon the home completion. This causes a catastrophe if the home request fails: the encoder position will no longer be reporting the correct value and the axis would not be able to home again until powercycled.

We are fixing this by separating the home and the backoff moves into two consecutive move groups, the MoveGroupRunner would now be able to stop the subsystem to perform a backoff move if the home request was not completed by condition.

@ahiuchingau ahiuchingau requested a review from a team as a code owner July 12, 2023 21:36
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #13095 (79922d7) into internal-release_0.13.0-beta-1 (2376f87) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                       Coverage Diff                       @@
##           internal-release_0.13.0-beta-1   #13095   +/-   ##
===============================================================
  Coverage                           72.81%   72.81%           
===============================================================
  Files                                2364     2364           
  Lines                               64472    64447   -25     
  Branches                             7191     7191           
===============================================================
- Hits                                46945    46930   -15     
+ Misses                              15848    15838   -10     
  Partials                             1679     1679           
Flag Coverage Δ
g-code-testing 96.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...entrons/hardware_control/backends/ot3controller.py 67.37% <ø> (+0.87%) ⬆️
...rc/opentrons/hardware_control/backends/ot3utils.py 91.66% <ø> (ø)

@ahiuchingau ahiuchingau merged commit eed0bef into internal-release_0.13.0-beta-1 Jul 13, 2023
@ahiuchingau ahiuchingau deleted the separate_home-backoff branch July 13, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant