Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC721 #584

Closed
wants to merge 62 commits into from
Closed

ERC721 #584

wants to merge 62 commits into from

Conversation

Amxx
Copy link
Contributor

@Amxx Amxx commented Mar 20, 2023 •
edited
Loading

Fixes #571.
Based on #583
Following the same structure as #581

PR Checklist

  • Tests
  • Tried the feature on a public network
  • Documentation

Notes:

  • Changes to src/openzeppelin/account.cairo are the result of make format

@martriay
Copy link
Contributor

please target the cairo-1 branch instead

@Amxx Amxx changed the base branch from main to cairo-1 March 21, 2023 13:07
@Amxx
Copy link
Contributor Author

Amxx commented Mar 21, 2023

Note that this PR was built on top of the account branch. The diff should greatly reduce when the account branch is merged into cairo-1

andrew-fleming
andrew-fleming reviewed Mar 24, 2023
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good, @Amxx! I left some feedback :)

src/openzeppelin/token/erc721.cairo Outdated Show resolved Hide resolved
src/openzeppelin/token/erc721.cairo Outdated Show resolved Hide resolved
src/openzeppelin/token/erc721.cairo Outdated Show resolved Hide resolved
src/openzeppelin/tests/test_erc721.cairo Show resolved Hide resolved
src/openzeppelin/tests/test_erc721.cairo Outdated Show resolved Hide resolved
src/openzeppelin/tests/test_erc721.cairo Outdated Show resolved Hide resolved
src/openzeppelin/token/erc721.cairo Outdated Show resolved Hide resolved
src/openzeppelin/token/erc721.cairo Outdated Show resolved Hide resolved
src/openzeppelin/token/erc721.cairo Outdated Show resolved Hide resolved
src/openzeppelin/token/erc721.cairo Show resolved Hide resolved
@Amxx Amxx requested review from martriay and andrew-fleming March 28, 2023 16:18
andrew-fleming
andrew-fleming reviewed Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@andrew-fleming andrew-fleming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I just left a tiny suggestion

src/openzeppelin/tests/test_erc721.cairo Show resolved Hide resolved
src/openzeppelin/token/erc721.cairo Show resolved Hide resolved
@andrew-fleming andrew-fleming mentioned this pull request Mar 29, 2023
Merged
3 tasks
This was referenced Apr 13, 2023
Merged
Merged
@martriay martriay mentioned this pull request May 21, 2023
Merged
@martriay
Copy link
Contributor

superseded by #619. thanks @Amxx for doing 99% of the work!

@martriay martriay closed this May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrew-fleming andrew-fleming andrew-fleming left review comments

@martriay martriay martriay approved these changes

@milancermak milancermak milancermak left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

migrate erc721 contracts
4 participants
@Amxx @martriay @milancermak @andrew-fleming