Migrate ERC20 #581
Closed
Migrate ERC20 #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amxx
reviewed
Mar 20, 2023
Comment on lines
+25
to
+26
| _balances: LegacyMap::<ContractAddress, u256>, | ||
| _allowances: LegacyMap::<(ContractAddress, ContractAddress), u256>, |
There was a problem hiding this comment.
Suggested change
| _balances: LegacyMap::<ContractAddress, u256>, | |
| _allowances: LegacyMap::<(ContractAddress, ContractAddress), u256>, | |
| _balances: LegacyMap<ContractAddress, u256>, | |
| _allowances: LegacyMap<(ContractAddress, ContractAddress), u256>, |
Amxx
reviewed
Mar 20, 2023
Comment on lines
+81
to
+83
| fn constructor(name: felt, symbol: felt, initial_supply: u256, recipient: ContractAddress) { | ||
| initializer(name, symbol, initial_supply, recipient); | ||
| } |
There was a problem hiding this comment.
In understand that we may want the constructor to mint an initial supply, but I'm not sure that should be part of the initializer
Suggested change
| fn constructor(name: felt, symbol: felt, initial_supply: u256, recipient: ContractAddress) { | |
| initializer(name, symbol, initial_supply, recipient); | |
| } | |
| fn constructor(name: felt, symbol: felt, initial_supply: u256, recipient: ContractAddress) { | |
| initializer(name, symbol); | |
| _mint(recipient, initial_supply); | |
| } |
Amxx
reviewed
Mar 20, 2023
Comment on lines
+144
to
+148
| fn initializer(name_: felt, symbol_: felt, initial_supply: u256, recipient: ContractAddress) { | ||
| _name::write(name_); | ||
| _symbol::write(symbol_); | ||
| _mint(recipient, initial_supply); | ||
| } |
There was a problem hiding this comment.
see comment in the constructor
Suggested change
| fn initializer(name_: felt, symbol_: felt, initial_supply: u256, recipient: ContractAddress) { | |
| _name::write(name_); | |
| _symbol::write(symbol_); | |
| _mint(recipient, initial_supply); | |
| } | |
| fn initializer(name_: felt, symbol_: felt) { | |
| _name::write(name_); | |
| _symbol::write(symbol_); | |
| } |
Amxx
reviewed
Mar 20, 2023
3 tasks
Amxx
reviewed
Mar 20, 2023
Comment on lines
+191
to
+199
| fn _spend_allowance(owner: ContractAddress, spender: ContractAddress, amount: u256) { | ||
| let current_allowance = _allowances::read((owner, spender)); | ||
| let ONES_MASK = 0xffffffffffffffffffffffffffffffff_u128; | ||
| let is_unlimited_allowance = | ||
| current_allowance.low == ONES_MASK & current_allowance.high == ONES_MASK; | ||
| if !is_unlimited_allowance { | ||
| _approve(owner, spender, current_allowance - amount); | ||
| } | ||
| } |
There was a problem hiding this comment.
With this proposal starkware-libs/cairo#2563 we could do:
Suggested change
| fn _spend_allowance(owner: ContractAddress, spender: ContractAddress, amount: u256) { | |
| let current_allowance = _allowances::read((owner, spender)); | |
| let ONES_MASK = 0xffffffffffffffffffffffffffffffff_u128; | |
| let is_unlimited_allowance = | |
| current_allowance.low == ONES_MASK & current_allowance.high == ONES_MASK; | |
| if !is_unlimited_allowance { | |
| _approve(owner, spender, current_allowance - amount); | |
| } | |
| } | |
| fn _spend_allowance(owner: ContractAddress, spender: ContractAddress, amount: u256) { | |
| let current_allowance = _allowances::read((owner, spender)); | |
| if is_unlimited_allowance != max_uint256() { | |
| _approve(owner, spender, current_allowance - amount); | |
| } | |
| } |
|
Superseded by #586 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #575 started by @andrew-fleming