Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Negative money balance after paid service #1173

Open
GermanAizek opened this issue Dec 21, 2022 · 0 comments
Open

Negative money balance after paid service #1173

GermanAizek opened this issue Dec 21, 2022 · 0 comments
Labels
good first issue Good start for beginners that want to contribute. Help wanted Vanilla Bug The original game issue.

Comments

@GermanAizek
Copy link
Contributor

GermanAizek commented Dec 21, 2022 •
edited by Xottab-DUTY
Loading

Describe the bug
Negative balance after a paid service if the player has less than the required amount.

To Reproduce
Steps to reproduce the behavior in Call of Pripyat:

  1. Watch video

Screenshots/Video

simplescreenrecorder-2022-12-21_20.35.02.mp4

Desktop:

  • OS: any
  • OpenXRay and original Clear Sky and Call of Pripyat
@GermanAizek GermanAizek added the Bug The issue in the run-time. label Dec 21, 2022
@Xottab-DUTY Xottab-DUTY added Vanilla Bug The original game issue. Help wanted good first issue Good start for beginners that want to contribute. and removed Bug The issue in the run-time. labels Dec 22, 2022
Vlad2001MFS added a commit to Vlad2001MFS/xray-16 that referenced this issue Jan 3, 2023
@Vlad2001MFS
xrGame: fix ability to get a negative money balance after paid service
7294e76 
Why:
Money was checked when player press to a some question in dialog. If player by buy something at this moment, then your money state will be changed, but a condition for a service dialog wil not be rechecked.

How:
Just reset a talk dialog state to initial when player press to a trade button.

Issue: OpenXRay#1173
@Vlad2001MFS Vlad2001MFS mentioned this issue Jan 3, 2023
Closed
@Xottab-DUTY Xottab-DUTY linked a pull request Mar 31, 2023 that will close this issue
xrGame: fix ability to get a negative money balance after paid service #1204
Closed
@Xottab-DUTY Xottab-DUTY mentioned this issue Oct 26, 2023
Open
@Xottab-DUTY Xottab-DUTY moved this to To do in Roadmap Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good start for beginners that want to contribute. Help wanted Vanilla Bug The original game issue.
Projects
Roadmap
Status: To do
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xrGame: fix ability to get a negative money balance after paid service Vlad2001MFS/xray-16
2 participants
@Xottab-DUTY @GermanAizek