Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/question_solvers #140

Merged
merged 5 commits into from
Apr 13, 2023
Merged

feat/question_solvers #140

merged 5 commits into from
Apr 13, 2023

Conversation

JarbasAl
Copy link
Member

@JarbasAl JarbasAl commented Apr 13, 2023

the plugin base class for question solvers was not in OPM

this moves it here to follow the convention of other plugins now that is is a core part of persona

includes NeonGeckoCom/neon_solvers#6

@JarbasAl JarbasAl added the enhancement New feature or request label Apr 13, 2023
@JarbasAl JarbasAl requested a review from a team April 13, 2023 20:47
the plugin base class for question solvers was not in OPM

this moves it here to follow the convention of other plugins now that is is a core part of persona

includes NeonGeckoCom/neon_solvers#6
@JarbasAl JarbasAl force-pushed the feat/question_solvers branch from e4ff6cd to 2ca8674 Compare April 13, 2023 20:48
@JarbasAl JarbasAl changed the title feat/extract_speech feat/question_solvers Apr 13, 2023
@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

❗ No coverage uploaded for pull request base (dev@92b5df4). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head e4ff6cd differs from pull request most recent head 29cfef7. Consider uploading reports for the commit 29cfef7 to get more accurate results

@@          Coverage Diff          @@
##             dev    #140   +/-   ##
=====================================
  Coverage       ?   0.00%           
=====================================
  Files          ?      48           
  Lines          ?    3510           
  Branches       ?       0           
=====================================
  Hits           ?       0           
  Misses         ?    3510           
  Partials       ?       0           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@JarbasAl JarbasAl merged commit 9cbdbe2 into dev Apr 13, 2023
@JarbasAl JarbasAl deleted the feat/question_solvers branch April 13, 2023 21:15
@github-actions github-actions bot mentioned this pull request Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant