bring up to date #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 4, 2023
NeonDaniel
requested changes
Feb 15, 2023
NeonDaniel
reviewed
Feb 15, 2023
neon_solvers/__init__.py
Outdated
| LOG.info(f"loaded question solver plugin: {plug_name}") | ||
| except Exception as e: | ||
| LOG.exception(f"Failed to load question solver plugin: {plug_name}") | ||
| config = self.config.get(plug) or {} |
There was a problem hiding this comment.
should be plug_name, not plug?
NeonDaniel
reviewed
Feb 15, 2023
neon_solvers/__init__.py
Outdated
| if not config.get("enabled", True): | ||
| continue | ||
| try: | ||
| config = self.config.get(plug) or {} |
JarbasAl
added a commit
to OpenVoiceOS/ovos-solver-openai-persona-plugin
that referenced
this pull request
Apr 13, 2023
JarbasAl
added a commit
to OpenVoiceOS/ovos-plugin-manager
that referenced
this pull request
Apr 13, 2023
the plugin base class for question solvers was not in OPM this moves it here to follow the convention of other plugins now that is is a core part of persona includes NeonGeckoCom/neon_solvers#6
JarbasAl
added a commit
to OpenVoiceOS/ovos-plugin-manager
that referenced
this pull request
Apr 13, 2023
the plugin base class for question solvers was not in OPM this moves it here to follow the convention of other plugins now that is is a core part of persona includes NeonGeckoCom/neon_solvers#6
|
replaced by OpenVoiceOS/ovos-plugin-manager#140 |
|
nvm, the service should stay here, only base class moved, will update PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for integration with OpenVoiceOS/ovos-backend-client#28