Fix 51bd344f10: Incorrect translation table used for older NewGRFs. #13131
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation / Problem
Incorrect logic was used to select the default translation table for older GRFs in #12646.
A litany of incorrect logic.
Description
No longer force-install a translation table. We don't revert back to the old ways of different logic to select cargo, we now just pick a prebuilt default translation table instead of installing it.
Pick the correct translation depending depending on context. In most cases this is:
In the one place where pre-v7 force uses the bitnums, then any installed table is ignored. This might not be correct, but it is the behaviour that was used prior to #12646.
Limitations
Checklist for review
Some things are not automated, and forgotten often. This list is a reminder for the reviewers.