[Bug]: Valuables dissappear from refitable cargo list for some of newgrfs

[tlpwka]

Version of OpenTTD

0.63.0

Expected result

As in 0.62.0, vehicles should have option to refit to valuables

Actual result

Cannot be refitted in 0.63.0

Impacted at least:

• Bobs random British vehicles
• Russian trucks v0.2
• Hungarian truck set v2.1

not impacted:

• eGRVTS v2.0
• Horse carts road vehicles set 1.2

Steps to reproduce

0.62.0.sav.zip
0.63.0.sav.zip

[JGRennison]

This GRF/climate configuration doesn't work for valuables in current vanilla OpenTTD either.
These vehicle sets are very old and don't interact particularly well with other NewGRFs.

Most likely the specific change is: OpenTTD/OpenTTD#12646

[tlpwka]

that is sad.
Do you think the impacted grfs will be hard to fix by myself (i did not checked other truck set if they have any issues)? I can't find source files for this particular sets, so there is only grfcodec option to decode them...

P.s.: I just done some additional testing: bug appears while using:

• opengfx industries with bank cargo set to valuables
• tested on arctic map,
• new game 2090, vehicles never expire

vanila 14.1:

• cargo refit to valuables is available for expected vehicles:
  

path 0.63:

• cargo refit not available

[PeterN]

Yeah, OpenTTD/OpenTTD#12646 fixes things for old vehicle sets that assumed the default cargo types are available. With non-default cargo types it was already mostly luck what happened, and was possibly not as intended -- without access to the original documentation or source there is no indication of what is expected.

GRF Overrides should allow the original cargo type properties and cargo classes to be set for these older GRFs, and OpenTTD/OpenTTD#12879 might help by letting other GRFs install an appropriate cargo translation table onto them, if fixing them natively is out of the question.

[PeterN]

I think OpenTTD/OpenTTD#13131 should fix most of these, although I've only tested with US Trains Set.