Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4 Migration #117

Merged
merged 26 commits into from
Feb 5, 2018
Merged

Swift 4 Migration #117

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
750f44d
[CoreSummit] Fixes closures syntax.
gcutrini Jan 2, 2018
94e66b5
[CoreSummit] Fixes reduce and sorted closures syntax.
gcutrini Jan 2, 2018
20c4305
[CoreSummit] Fixes range at syntax.
gcutrini Jan 2, 2018
613460c
[watchOS] Fixes reduce and sorted closures syntax.
gcutrini Jan 3, 2018
a32b75a
[watchOS] Fixes html to attributed string conversion.
gcutrini Jan 3, 2018
6cd15cf
[iOS] Fixes reduce and sorted closures syntax.
gcutrini Jan 4, 2018
79bc8f1
[iOS] Fixes closures syntax.
gcutrini Jan 4, 2018
1618d93
[iOS] Fixes attributed text keys syntax.
gcutrini Jan 4, 2018
015c2fb
[iOS] Adds new function signature to match expected argument type.
gcutrini Jan 5, 2018
e68e6f8
[iOS] Disambiguiates type(of: self) usage.
gcutrini Jan 5, 2018
cdfff06
[iOS] Fixes mocked summit store call.
gcutrini Jan 5, 2018
49d271b
[macOS] Fixes closures syntax.
gcutrini Jan 5, 2018
3fe2327
[macOS] Fixes html to attributed string conversion.
gcutrini Jan 8, 2018
804c9a6
[macOS] Migrates to swift 4 syntax.
gcutrini Jan 8, 2018
4f12d1d
[macOS] Makes segues strings into identifiers.
gcutrini Jan 8, 2018
f2c11fa
[iOS] Adds missing event kit default calendar unwrapping.
gcutrini Jan 8, 2018
059e9b4
[iOS] Adds @objc attribute for minimal inference.
gcutrini Jan 9, 2018
44ab67b
[tvOS] Fixes closure syntax.
gcutrini Jan 9, 2018
d42ac30
[tvOS] Fixes html to attributed string conversion.
gcutrini Jan 9, 2018
44c56e7
[tvOS] Coverts metadata identifier syntax.
gcutrini Jan 9, 2018
06edf7a
[CoreSummit] Treats string as collection.
gcutrini Jan 9, 2018
813dc71
[iOS] Treats string as collection.
gcutrini Jan 9, 2018
c2a48de
Updates R.swift.Library dependency.
gcutrini Jan 9, 2018
594c52e
Updates XLPagerTabStrip dependency.
gcutrini Jan 10, 2018
655d989
Updates Cosmos dependency.
gcutrini Jan 10, 2018
9dadbbf
Updates project and settings to target swift 4.
gcutrini Jan 10, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions OpenStack Summit/OpenStackSummit macOS/EventDetailViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,13 +349,13 @@ final class EventDetailViewController: NSViewController, ContentController, Mess

switch segue.identifier! {

case "showEventVenue":
case .showEventVenue:

let venueDetailViewController = segue.destinationController as! VenueDetailViewController

venueDetailViewController.venue = eventDetail.venue!.venue

case "showEventSpeakers":
case .showEventSpeakers:

let speakersViewController = segue.destinationController as! SpeakersTableViewController

Expand All @@ -376,3 +376,9 @@ final class EventDetailViewController: NSViewController, ContentController, Mess
}
}
}

extension NSStoryboardSegue.Identifier {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!


static let showEventVenue = NSStoryboardSegue.Identifier("showEventVenue")
static let showEventSpeakers = NSStoryboardSegue.Identifier("showEventSpeakers")
}