Swift 4 Migration #117
Merged
Swift 4 Migration #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
objc inference still set to match swift 3 behaviour
|
I already implemented the Codable API. The code is hosted here: https://github.com/colemancda/CoreDataCodable/blob/master/Tests/CoreDataCodableTests/TestSummitJSON.swift Basically there are 3 model types now: This is because the JSON can have a 1-1 representation to a decodable model, but there are values (e.g. If you want you can copy and paste these 3 files to have the Codable model. https://github.com/colemancda/CoreDataCodable/blob/master/Tests/CoreDataCodableTests/TestSummitJSON.swift And don't forget to add |
colemancda
suggested changes
Jan 12, 2018
There was a problem hiding this comment.
Add https://github.com/colemancda/CoreDataCodable
And the Codable Summit Model found in https://github.com/colemancda/CoreDataCodable/tree/master/Tests/CoreDataCodableTests
|
I also modified the CoreData Model |
colemancda
reviewed
Jan 12, 2018
| @@ -376,3 +376,9 @@ final class EventDetailViewController: NSViewController, ContentController, Mess | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| extension NSStoryboardSegue.Identifier { | |||
|
@colemancda merging as is. |
Merged
JpMaxMan
pushed a commit
that referenced
this pull request
Mar 22, 2018
* [iOS] [13314] Fixes venue map zoom defaults. * Restores OAuth2 access revoked notification handling. Updates aerogear-ios-oauth2 lib. * [iOS] [13370] Splash fallbacks to loaded summit name and date display. * [iOS] [13431] Updates NOW button logic. * Version bump to 3.0.2. * Updates oauth2 lib with token refresh getter fix. * Version bump to 3.0.3. * Updates oauth lib to allow keychain tokens read when device is locked. * Version bump to 3.0.4. * Resets oauth keychain by changing accounts prefix. * Version bump to 3.0.5. * Revert "Version bump to 3.0.5." This reverts commit 35f3d89. * [CoreSummit] [tvOS] Fixed tvOS compiler crash Hopefully this will be fixed in the future * Revert "[CoreSummit] [tvOS] Fixed tvOS compiler crash" This reverts commit fe5647d. * [CoreSummit] Fixes compiler crash. Removes redundant conformance constraint. * Updates ImageSlideshow dependency. For swift(>=3.2) compatibility. * Updates XCDYouTubeKit dependency. * Swift 4 Migration (#117) * [CoreSummit] Fixes closures syntax. * [CoreSummit] Fixes reduce and sorted closures syntax. * [CoreSummit] Fixes range at syntax. * [watchOS] Fixes reduce and sorted closures syntax. * [watchOS] Fixes html to attributed string conversion. * [iOS] Fixes reduce and sorted closures syntax. * [iOS] Fixes closures syntax. * [iOS] Fixes attributed text keys syntax. * [iOS] Adds new function signature to match expected argument type. * [iOS] Disambiguiates type(of: self) usage. * [iOS] Fixes mocked summit store call. * [macOS] Fixes closures syntax. * [macOS] Fixes html to attributed string conversion. * [macOS] Migrates to swift 4 syntax. * [macOS] Makes segues strings into identifiers. * [iOS] Adds missing event kit default calendar unwrapping. * [iOS] Adds @objc attribute for minimal inference. * [tvOS] Fixes closure syntax. * [tvOS] Fixes html to attributed string conversion. * [tvOS] Coverts metadata identifier syntax. * [CoreSummit] Treats string as collection. * [iOS] Treats string as collection. * Updates R.swift.Library dependency. * Updates XLPagerTabStrip dependency. * Updates Cosmos dependency. * Updates project and settings to target swift 4. objc inference still set to match swift 3 behaviour * [iOS] [12678] Rearranges My Summit tabs. * [iOS] Removes schedule view duplicate constraints. * [iOS] Fixes schedule view content view layout bug. * [iOS] Fixes venue detail slideshow full screen image selection. * [iOS] Renames slideshow input source type. * [iOS] [11351] Links location to floor map. * [iOS] [13513] Adds filter by track. * [iOS] [11887] Adds schedule url deep linking. * Renames schedule active dates methods. * [CoreSummit] Fixes summits request. * [iOS] [13776] Improves splash screen transitioning state. * [iOS] [13776] Fixes splash screen logo size. * [iOS] [13776] Adds day counters to splash screen. * [iOS] [13776] Fixes label instances tracking bug. * [iOS] [13776] Fixes summit name bug. * Version bump to 3.0.5. * [iOS] Adds borders to now button.
gcutrini
added a commit
that referenced
this pull request
Oct 18, 2018
* [iOS] [13314] Fixes venue map zoom defaults. * Restores OAuth2 access revoked notification handling. Updates aerogear-ios-oauth2 lib. * [iOS] [13370] Splash fallbacks to loaded summit name and date display. * [iOS] [13431] Updates NOW button logic. * Version bump to 3.0.2. * Updates oauth2 lib with token refresh getter fix. * Version bump to 3.0.3. * Updates oauth lib to allow keychain tokens read when device is locked. * Version bump to 3.0.4. * Resets oauth keychain by changing accounts prefix. * Version bump to 3.0.5. * Revert "Version bump to 3.0.5." This reverts commit 35f3d89. * [CoreSummit] [tvOS] Fixed tvOS compiler crash Hopefully this will be fixed in the future * Revert "[CoreSummit] [tvOS] Fixed tvOS compiler crash" This reverts commit fe5647d. * [CoreSummit] Fixes compiler crash. Removes redundant conformance constraint. * Updates ImageSlideshow dependency. For swift(>=3.2) compatibility. * Updates XCDYouTubeKit dependency. * Swift 4 Migration (#117) * [CoreSummit] Fixes closures syntax. * [CoreSummit] Fixes reduce and sorted closures syntax. * [CoreSummit] Fixes range at syntax. * [watchOS] Fixes reduce and sorted closures syntax. * [watchOS] Fixes html to attributed string conversion. * [iOS] Fixes reduce and sorted closures syntax. * [iOS] Fixes closures syntax. * [iOS] Fixes attributed text keys syntax. * [iOS] Adds new function signature to match expected argument type. * [iOS] Disambiguiates type(of: self) usage. * [iOS] Fixes mocked summit store call. * [macOS] Fixes closures syntax. * [macOS] Fixes html to attributed string conversion. * [macOS] Migrates to swift 4 syntax. * [macOS] Makes segues strings into identifiers. * [iOS] Adds missing event kit default calendar unwrapping. * [iOS] Adds @objc attribute for minimal inference. * [tvOS] Fixes closure syntax. * [tvOS] Fixes html to attributed string conversion. * [tvOS] Coverts metadata identifier syntax. * [CoreSummit] Treats string as collection. * [iOS] Treats string as collection. * Updates R.swift.Library dependency. * Updates XLPagerTabStrip dependency. * Updates Cosmos dependency. * Updates project and settings to target swift 4. objc inference still set to match swift 3 behaviour * [iOS] [12678] Rearranges My Summit tabs. * [iOS] Removes schedule view duplicate constraints. * [iOS] Fixes schedule view content view layout bug. * [iOS] Fixes venue detail slideshow full screen image selection. * [iOS] Renames slideshow input source type. * [iOS] [11351] Links location to floor map. * [iOS] [13513] Adds filter by track. * [iOS] [11887] Adds schedule url deep linking. * Renames schedule active dates methods. * [CoreSummit] Fixes summits request. * [iOS] [13776] Improves splash screen transitioning state. * [iOS] [13776] Fixes splash screen logo size. * [iOS] [13776] Adds day counters to splash screen. * [iOS] [13776] Fixes label instances tracking bug. * [iOS] [13776] Fixes summit name bug. * Version bump to 3.0.5. * Fixes delete persistence store call ambiguity. * [iOS] [14023] Fixes filters equatable bug. * [iOS] Adds borders to now button. * [iOS] Updates Google Maps to v2.7.0 * [CoreSummit] Fixes summit data update processing. * Adds data updates unit tests. * Updates Crashalytics dependecy. Fixes: -[ANSWriteEventOperation logLineWithTimestamp:eventName:payloadDictionary:] Raw Text * +[NSJSONSerialization dataWithJSONObject:options:error:]: value parameter is nil * [CoreSummit] Prevents concurrent data update polling. Updates event data update test json data. * [Core Summit] Clears data update storage if no active summit. * [CoreSummit] Skips data update processing if data wiping. Simplifies data update processing error recording. * [CoreSummit] [iOS] Revamps data update error logging to Fabric. * [iOS] Adds logging to view controllers api error. * [iOS] [14135] Changes button wording. * [iOS] [14182] Changes event detail section name wording. * [iOS] [14075] Fixes deep linking UI transitioning. * [iOS] Fixes layout bug caused by front view being pushed again to front. * [iOS] Prevents consecutive presses on menu items. * [iOS] [14218] Changes filter name wording. * [iOS] [14179] Adds filtering by video. * [cespinoza] - #14106 (#119) * Add CONTRIBUTING.md * [CoreSummit] [iOS] Checks allowed3 redirect url to identify IDP deep linking. Defers event viewing after data load completion. * [CoreSummit] Adds auth revoke and retry on service account api calls. * [iOS] Adds event search by presentation speaker or moderator. * [iOS] [14393] Fixes duplicated biography. Caused by race condition. * Version bump to 3.0.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated code and dependencies.
Still missing implementing Codable API for JSON representation.