fix(app): Show 404 pages on more invalid route paths (root and error pages)

packages/openneuro-app/src/scripts/errors/errorRoute.jsx

@@ -7,22 +7,22 @@
 import OrcidEmail from "./orcid/email.jsx"
 import OrcidGiven from "./orcid/given.jsx"
 import OrcidFamily from "./orcid/family.jsx"
+import FourOFourPage from "./404page"
 
-class ErrorRoute extends React.Component {
-  render() {
-    return (
-      <div className="container errors">
-        <div className="panel">
-          <Routes>
-            <Route path="orcid" element={<OrcidGeneral />} />
-            <Route path="orcid/email" element={<OrcidEmail />} />
-            <Route path="orcid/given" element={<OrcidGiven />} />
-            <Route path="orcid/family" element={<OrcidFamily />} />
-          </Routes>
-        </div>
+function ErrorRoute() {
+  return (
+    <div className="container errors">
+      <div className="panel">
+        <Routes>
+          <Route path="orcid" element={<OrcidGeneral />} />
+          <Route path="orcid/email" element={<OrcidEmail />} />
+          <Route path="orcid/given" element={<OrcidGiven />} />
+          <Route path="orcid/family" element={<OrcidFamily />} />
+          <Route path="*" element={<FourOFourPage />} />
+        </Routes>
       </div>
-    )
-  }
+    </div>
+  )
 }
 
 export default ErrorRoute

packages/openneuro-app/src/scripts/routes.tsx

@@ -39,7 +39,7 @@
       path="/dashboard"
       element={<Navigate to="/search?mydatasets" replace />}
     />
-    <Route element={<FourOFourPage />} />
+    <Route path="/*" element={<FourOFourPage />} />
   </Routes>
 )