Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app): Show 404 pages on more invalid route paths (root and error pages) #3061

Merged
merged 1 commit into from
May 21, 2024

Conversation

nellh
Copy link
Contributor

@nellh nellh commented May 21, 2024

Fixes a bug where sometimes the 404 page would not be displayed for an invalid path when it matched part of a valid path.

Copy link

codecov bot commented May 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes are missing coverage. Please review.

Project coverage is 42.48%. Comparing base (29e4511) to head (24b61c5).
Report is 2 commits behind head on master.

Files Patch % Lines
...es/openneuro-app/src/scripts/errors/errorRoute.jsx 0.00% 14 Missing ⚠️
packages/openneuro-app/src/scripts/routes.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3061   +/-   ##
=======================================
  Coverage   42.48%   42.48%           
=======================================
  Files         601      601           
  Lines       37986    37986           
  Branches     1113     1113           
=======================================
  Hits        16138    16138           
  Misses      21632    21632           
  Partials      216      216           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nellh nellh merged commit 75ea7be into master May 21, 2024
10 of 11 checks passed
@nellh nellh deleted the error-updates branch May 21, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant